Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the failing GitHub Actions #67

Merged
merged 9 commits into from
May 16, 2024
Merged

Conversation

eytanadler
Copy link
Collaborator

@eytanadler eytanadler commented May 9, 2024

Purpose

Fix the GitHub Actions failures on the MacOS builds when setting up Python.

SciPy 1.6.0 wasn't working on the ARM Mac builds, so I've bumped the minimum SciPy version from 1.6.0 to 1.7.0, which now works correctly.

Finally, this has some minor codecov changes that seem to work better now (the main changes were a new token in the OpenConcept secrets and bumping the codecov action to version 4).

Type of change

What types of change is it?
Select the appropriate type(s) that describe this PR

  • Bugfix (non-breaking change which fixes an issue)

@eytanadler eytanadler requested a review from a team as a code owner May 9, 2024 20:07
Copy link

codecov bot commented May 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.08%. Comparing base (ed14c54) to head (63eecf4).

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #67   +/-   ##
=======================================
  Coverage   82.08%   82.08%           
=======================================
  Files         103      103           
  Lines       10717    10717           
=======================================
  Hits         8797     8797           
  Misses       1920     1920           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lamkina
Copy link

lamkina commented May 14, 2024

@eytanadler is this ready for a review? The checks are hanging, but it seems that might be what this PR is addressing?

@eytanadler
Copy link
Collaborator Author

Yes it's ready. The checks are hanging because they changed name (1.6.0 -> 1.7.0), so the required ones I have setup are no longer valid. If you're good with these changes I can fix it

@eytanadler eytanadler merged commit fb9bae6 into mdolab:main May 16, 2024
13 checks passed
@eytanadler eytanadler deleted the GHA_fix branch May 16, 2024 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants