Fix the failing GitHub Actions #67
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #67 +/- ##
=======================================
Coverage 82.08% 82.08%
=======================================
Files 103 103
Lines 10717 10717
=======================================
Hits 8797 8797
Misses 1920 1920 ☔ View full report in Codecov by Sentry. |
|
@eytanadler is this ready for a review? The checks are hanging, but it seems that might be what this PR is addressing? |
|
Yes it's ready. The checks are hanging because they changed name (1.6.0 -> 1.7.0), so the required ones I have setup are no longer valid. If you're good with these changes I can fix it |
lamkina
approved these changes
May 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Fix the GitHub Actions failures on the MacOS builds when setting up Python.
SciPy 1.6.0 wasn't working on the ARM Mac builds, so I've bumped the minimum SciPy version from 1.6.0 to 1.7.0, which now works correctly.
Finally, this has some minor codecov changes that seem to work better now (the main changes were a new token in the OpenConcept secrets and bumping the codecov action to version 4).
Type of change
What types of change is it?
Select the appropriate type(s) that describe this PR