Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed a typo and takeoff plotting #68

Merged
merged 1 commit into from
May 31, 2024
Merged

Conversation

kanekosh
Copy link
Contributor

Purpose

Fixed a minor typo in the docs for the takeoff analysis. Also changed the marker style to default "o" to avoid plotting the nominal takeoff and the emergency stop in one continuous line.

Type of change

What types of change is it?
Select the appropriate type(s) that describe this PR

  • Documentation update

Checklist

Put an x in the boxes that apply.

  • I have run unit and regression tests which pass locally with my changes
  • I have added new tests that prove my fix is effective or that my feature works
  • I have added necessary documentation

@kanekosh kanekosh requested a review from a team as a code owner May 31, 2024 20:26
Copy link

codecov bot commented May 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.08%. Comparing base (fb9bae6) to head (38741c4).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #68   +/-   ##
=======================================
  Coverage   82.08%   82.08%           
=======================================
  Files         103      103           
  Lines       10717    10717           
=======================================
  Hits         8797     8797           
  Misses       1920     1920           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@eytanadler
Copy link
Collaborator

Good catch!

@kanekosh kanekosh merged commit 7ab3c6a into mdolab:main May 31, 2024
13 checks passed
@kanekosh kanekosh deleted the takeoff_viz branch May 31, 2024 22:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants