Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix camelcase to be consistent with adflow #169

Merged
merged 3 commits into from
Dec 13, 2022

Conversation

anilyil
Copy link
Contributor

@anilyil anilyil commented Dec 13, 2022

Purpose

Changed instances of coord_xfer to coordXfer based on the changes requested in my ADflow PR: mdolab/adflow#231

Expected time until merged

1-2 days.

Type of change

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (non-backwards-compatible fix or feature)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Documentation update
  • Maintenance update
  • Other (please describe)

Testing

Checklist

  • I have run flake8 and black to make sure the Python code adheres to PEP-8 and is consistently formatted
  • I have formatted the Fortran code with fprettify or C/C++ code with clang-format as applicable
  • I have run unit and regression tests which pass locally with my changes
  • I have added new tests that prove my fix is effective or that my feature works
  • I have added necessary documentation

gawng
gawng previously approved these changes Dec 13, 2022
Copy link
Contributor

@gawng gawng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Provided that all the checks pass (they should), this looks good to merge

@gawng gawng self-requested a review December 13, 2022 04:43
@codecov
Copy link

codecov bot commented Dec 13, 2022

Codecov Report

Merging #169 (a04aab0) into main (d3f2415) will decrease coverage by 0.83%.
The diff coverage is 84.61%.

@@            Coverage Diff             @@
##             main     #169      +/-   ##
==========================================
- Coverage   64.14%   63.30%   -0.84%     
==========================================
  Files          47       47              
  Lines       11866    11866              
==========================================
- Hits         7611     7512      -99     
- Misses       4255     4354      +99     
Impacted Files Coverage Δ
pygeo/parameterization/DVGeo.py 66.34% <84.61%> (-0.05%) ⬇️
pygeo/constraints/areaConstraint.py 50.50% <0.00%> (-25.42%) ⬇️
pygeo/constraints/DVCon.py 68.48% <0.00%> (-3.25%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@eirikurj eirikurj merged commit 5d42e7d into mdolab:main Dec 13, 2022
@anilyil anilyil deleted the fixCamelCase branch December 13, 2022 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants