Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update minimum required versions #262

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Update minimum required versions #262

wants to merge 2 commits into from

Conversation

A-CGray
Copy link
Member

@A-CGray A-CGray commented Feb 28, 2025

Purpose

For https://github.com/mdolab/docker/issues/271.

We should make the 1.15.0 release once this is merged

Expected time until merged

NOW!

Type of change

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (non-backwards-compatible fix or feature)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Documentation update
  • Maintenance update
  • Other (please describe)

Testing

Checklist

  • I have run flake8 and black to make sure the Python code adheres to PEP-8 and is consistently formatted
  • I have formatted the Fortran code with fprettify or C/C++ code with clang-format as applicable
  • I have run unit and regression tests which pass locally with my changes
  • I have added new tests that prove my fix is effective or that my feature works
  • I have added necessary documentation

@A-CGray A-CGray requested a review from a team as a code owner February 28, 2025 19:07
Copy link

codecov bot commented Feb 28, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.02%. Comparing base (ba45e83) to head (33ae261).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #262   +/-   ##
=======================================
  Coverage   67.02%   67.02%           
=======================================
  Files          47       47           
  Lines       12326    12326           
=======================================
  Hits         8261     8261           
  Misses       4065     4065           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@marcomangano
Copy link
Contributor

@A-CGray do we want to bump the minor version here?

@marcomangano
Copy link
Contributor

After #264 is merged maybe?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants