Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add helper function for creating midsurface (a.k.a VLM) meshes #265

Open
wants to merge 10 commits into
base: main
Choose a base branch
from

Conversation

A-CGray
Copy link
Member

@A-CGray A-CGray commented Mar 11, 2025

Purpose

Adds a helper function that uses a very similar approach to the fitted FFD generation code to generate a midsurface mesh of a wing, that can then be used in a VLM code. The generated meshes follow the camber line of each section of the wing, for example:
VLMMesh

I added a test that uses a new input file that I guess I need to upload somewhere?

Expected time until merged

No rush

Type of change

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (non-backwards-compatible fix or feature)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Documentation update
  • Maintenance update
  • Other (please describe)

Testing

Checklist

  • I have run flake8 and black to make sure the Python code adheres to PEP-8 and is consistently formatted
  • I have formatted the Fortran code with fprettify or C/C++ code with clang-format as applicable
  • I have run unit and regression tests which pass locally with my changes
  • I have added new tests that prove my fix is effective or that my feature works
  • I have added necessary documentation

@A-CGray A-CGray requested a review from a team as a code owner March 11, 2025 21:22
@A-CGray A-CGray requested review from hajdik and ArshSaja March 11, 2025 21:22
@A-CGray A-CGray requested a review from sabakhshi March 11, 2025 21:43
@A-CGray A-CGray removed the request for review from hajdik March 11, 2025 22:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant