Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed BC option indenting #34

Merged
merged 2 commits into from
Dec 11, 2020
Merged

Fixed BC option indenting #34

merged 2 commits into from
Dec 11, 2020

Conversation

sseraj
Copy link
Collaborator

@sseraj sseraj commented Dec 8, 2020

Purpose

When I was merging the formatting changes from #31 into #33, I inadvertently indented a line that was not supposed to be indented. This broke the BC option. This PR fixes the indenting.

Type of change

What types of change is it?
Select the appropriate type(s) that describe this PR

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (non-backwards-compatible fix or feature)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Documentation update
  • Maintenance update
  • Other (please describe)

@sseraj sseraj requested a review from a team as a code owner December 8, 2020 02:50
@sseraj
Copy link
Collaborator Author

sseraj commented Dec 8, 2020

I also incremented the version number so I can make a new release after this is merged.

Copy link
Contributor

@eirikurj eirikurj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. To prevent this happening again we should put in tests that check if the BCs are what they are supposed to be. I think there should be two tests: 1) unittest that checks the code, and 2) regression file tests that checks the output CGNS file is consistent. I have added an issue #35 for this.

@marcomangano
Copy link
Contributor

Is this ready to go? Probably (not only) this issue messed up with my unattachededgesaresymmetry: False extrusion attempts, looking forward to try the bugfix :)

@sseraj
Copy link
Collaborator Author

sseraj commented Dec 11, 2020

Yes, this is good to go.

@eirikurj
Copy link
Contributor

eirikurj commented Dec 11, 2020

From my point of view, yes. I was waiting for a second review and perhaps hoping for some type of discussion on how we can prevent this happening. I guess we can direct that to #35. Will merge.

@eirikurj eirikurj merged commit 855c444 into mdolab:master Dec 11, 2020
@sseraj sseraj deleted the BCfix branch December 29, 2020 23:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants