NSGA2 patch

[ewu63]

Purpose

Merge the patch from conda-forge/pyoptsparse-feedstock#36 upstream.

Expected time until merged

1 week

Type of change

• Bugfix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (non-backwards-compatible fix or feature)
• Code style update (formatting, renaming)
• Refactoring (no functional changes, no API changes)
• Documentation update
• Maintenance update
• Other (please describe)

Testing

Checklist

• I have run flake8 and black to make sure the Python code adheres to PEP-8 and is consistently formatted
• I have formatted the Fortran code with fprettify or C/C++ code with clang-format as applicable
• I have run unit and regression tests which pass locally with my changes
• I have added new tests that prove my fix is effective or that my feature works
• I have added necessary documentation

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (c233e8f) 73.34% compared to head (dee7a09) 61.58%.

Additional details and impacted files

@@             Coverage Diff             @@
##             main     #365       +/-   ##
===========================================
- Coverage   73.34%   61.58%   -11.77%     
===========================================
  Files          22       22               
  Lines        3316     3316               
===========================================
- Hits         2432     2042      -390     
- Misses        884     1274      +390     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[ewu63]

Just rebased the code @marcomangano @ArshSaja

[eirikurj]

Strange that this is showing up now. @nwu63 for my information, what triggered this, and what was the system/compiler? Also, why is codecov reporting a large drop?

[ewu63]

Strange that this is showing up now. @nwu63 for my information, what triggered this, and what was the system/compiler? Also, why is codecov reporting a large drop?

@whophil did this for the mac build, not sure what the root cause was. Maybe something changed in the toolchain within conda?
Coverage change is due to the PR being submitted on a fork, so some optimizers are skipped. Those should be irrelevant since there are only NSGA2-related changes here, which are covered in the public images.

[whophil]

@eirikurj @nwu63 the problem this patch was meant to fix first started appearing on builds after conda-forge moved from clang(x) 15 to 16 for Mac builds. I don't suppose this project is built with clang compilers on CI, but I imagine the error could be reproduced by attempting a build of the main branch with clang 16.

[whophil]

Here is a relevant excerpt from the Clang 16 release notes (https://releases.llvm.org/16.0.0/tools/clang/docs/ReleaseNotes.html)

The -Wimplicit-function-declaration and -Wimplicit-int warnings now default to an error in C99, C11, and C17. As of C2x, support for implicit function declarations and implicit int has been removed, and the warning options will have no effect. Specifying -Wimplicit-int in C89 mode will now issue warnings instead of being a noop.

[eirikurj]

Thanks for the info. I looked a bit into this with GCC and there is a warning that is thrown,

../pyoptsparse/pyNSGA2/source/eval.c:25:5: warning: implicit declaration of function ‘nsga2func’ [-Wimplicit-function-declaration]

The patch removes this warning.

[ewu63]

Bump @marcomangano @ArshSaja

[marcomangano]

Thanks for taking care of this, LGTM. Making a new release asap so that the patch can be removed from conda-forge