Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed convertJacobian #371

Merged
merged 4 commits into from
Dec 22, 2023
Merged

fixed convertJacobian #371

merged 4 commits into from
Dec 22, 2023

Conversation

gjkennedy
Copy link
Contributor

call when jacType == "csr" so that it retuns CSR data instead of passing through

Purpose

Minor bug fix

Expected time until merged

Type of change

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (non-backwards-compatible fix or feature)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Documentation update
  • Maintenance update
  • Other (please describe)

Testing

I checked it using ParOptSparse which requires the Jacobian matrix in a CSR structure

Checklist

  • I have run flake8 and black to make sure the Python code adheres to PEP-8 and is consistently formatted
  • I have formatted the Fortran code with fprettify or C/C++ code with clang-format as applicable
  • I have run unit and regression tests which pass locally with my changes
  • I have added new tests that prove my fix is effective or that my feature works
  • I have added necessary documentation

@gjkennedy gjkennedy requested a review from a team as a code owner December 7, 2023 14:31
Copy link

codecov bot commented Dec 7, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (5fef213) 73.34% compared to head (b97db72) 61.60%.

Files Patch % Lines
pyoptsparse/pyOpt_optimizer.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main     #371       +/-   ##
===========================================
- Coverage   73.34%   61.60%   -11.74%     
===========================================
  Files          22       22               
  Lines        3316     3318        +2     
===========================================
- Hits         2432     2044      -388     
- Misses        884     1274      +390     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@marcomangano marcomangano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay, LGTM

@marcomangano marcomangano merged commit 8d43112 into mdolab:main Dec 22, 2023
12 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants