Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update meson version for windows #375

Merged
merged 10 commits into from
Feb 15, 2024
Merged

Conversation

ewu63
Copy link
Collaborator

@ewu63 ewu63 commented Jan 11, 2024

Purpose

Now that mesonbuild/meson#10778 is fixed in release 1.3.1, I bumped the meson version in the environment.yml file.

Expected time until merged

Type of change

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (non-backwards-compatible fix or feature)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Documentation update
  • Maintenance update
  • Other (please describe)

Testing

Checklist

  • I have run flake8 and black to make sure the Python code adheres to PEP-8 and is consistently formatted
  • I have formatted the Fortran code with fprettify or C/C++ code with clang-format as applicable
  • I have run unit and regression tests which pass locally with my changes
  • I have added new tests that prove my fix is effective or that my feature works
  • I have added necessary documentation

@ewu63 ewu63 requested a review from a team as a code owner January 11, 2024 01:04
Copy link

codecov bot commented Jan 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (7f26d43) 73.35% compared to head (cb1f639) 61.60%.

Additional details and impacted files
@@             Coverage Diff             @@
##             main     #375       +/-   ##
===========================================
- Coverage   73.35%   61.60%   -11.76%     
===========================================
  Files          22       22               
  Lines        3318     3318               
===========================================
- Hits         2434     2044      -390     
- Misses        884     1274      +390     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@marcomangano
Copy link
Contributor

It looks like there are still issues with flang - This is from the tests printout:

meson.build:31:0: ERROR: Unable to detect linker for compiler `flang -Wl,--version`
stdout: LINK : warning LNK4044: unrecognized option '/-version'; ignored
LINK : warning LNK4001: no object files specified; libraries used
LINK : warning LNK4068: /MACHINE not specified; defaulting to X64
flangmain.lib(flangmain.c.obj) : error LNK2019: unresolved external symbol MAIN_ referenced in function main
a.exe : fatal error LNK1120: 1 unresolved externals

stderr: flang.exe: error: linker command failed with exit code 1120 (use -v to see invocation)

@marcomangano
Copy link
Contributor

@nwu63 I figured out why this PR is still failing: the bugfix has not actually been included in the 1.3.1 release. Since we are getting meson via pip we need to wait for a new release - I don't believe this is urgent enough to require other workarounds?

@ewu63
Copy link
Collaborator Author

ewu63 commented Feb 5, 2024

Thanks for looking this up. Let's wait for a new version then.

Copy link
Contributor

@marcomangano marcomangano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I missed the new release, thanks for catching this

@marcomangano marcomangano merged commit 604aeda into mdolab:main Feb 15, 2024
12 of 13 checks passed
@ewu63 ewu63 deleted the update-meson-windows branch February 15, 2024 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants