-
Notifications
You must be signed in to change notification settings - Fork 109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update meson version for windows #375
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #375 +/- ##
===========================================
- Coverage 73.35% 61.60% -11.76%
===========================================
Files 22 22
Lines 3318 3318
===========================================
- Hits 2434 2044 -390
- Misses 884 1274 +390 ☔ View full report in Codecov by Sentry. |
It looks like there are still issues with
|
@nwu63 I figured out why this PR is still failing: the bugfix has not actually been included in the 1.3.1 release. Since we are getting |
Thanks for looking this up. Let's wait for a new version then. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I missed the new release, thanks for catching this
Purpose
Now that mesonbuild/meson#10778 is fixed in release 1.3.1, I bumped the meson version in the
environment.yml
file.Expected time until merged
Type of change
Testing
Checklist
flake8
andblack
to make sure the Python code adheres to PEP-8 and is consistently formattedfprettify
or C/C++ code withclang-format
as applicable