Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decreased time limit for SNOPT informs test #376

Merged
merged 1 commit into from
Jan 15, 2024
Merged

Conversation

sseraj
Copy link
Collaborator

@sseraj sseraj commented Jan 12, 2024

Purpose

Our Mac runner is fast and sometimes does not run into the time limit for the SNOPT test where we want the optimization to time out. I decreased the time limit to hopefully address this.

Expected time until merged

2-3 days

Type of change

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (non-backwards-compatible fix or feature)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Documentation update
  • Maintenance update
  • Other (please describe)

Testing

The test still works on my workstation, but I didn't test this on the Mac runner.

Checklist

  • I have run flake8 and black to make sure the Python code adheres to PEP-8 and is consistently formatted
  • I have formatted the Fortran code with fprettify or C/C++ code with clang-format as applicable
  • I have run unit and regression tests which pass locally with my changes
  • I have added new tests that prove my fix is effective or that my feature works
  • I have added necessary documentation

@sseraj sseraj requested a review from a team as a code owner January 12, 2024 16:04
Copy link

codecov bot commented Jan 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (8d43112) 73.35% compared to head (9ff2f03) 73.35%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #376   +/-   ##
=======================================
  Coverage   73.35%   73.35%           
=======================================
  Files          22       22           
  Lines        3318     3318           
=======================================
  Hits         2434     2434           
  Misses        884      884           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@lamkina lamkina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Simple enough solution since we are only testing if it produces the correct informs from SNOPT. LGTM.

@marcomangano marcomangano merged commit eee3f70 into main Jan 15, 2024
13 checks passed
@marcomangano marcomangano deleted the time-limit branch January 15, 2024 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants