Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update paropt interface #385

Merged
merged 1 commit into from
Feb 22, 2024
Merged

Update paropt interface #385

merged 1 commit into from
Feb 22, 2024

Conversation

ewu63
Copy link
Collaborator

@ewu63 ewu63 commented Feb 21, 2024

Purpose

Closes #384

Note that we are not currently testing any version other than v2.0.2, but the changes here should be backwards compatible (assuming tests pass). This will be more meaningful once we have the newer version up and running, but in the mean time it should provide a stopgap solution.

Expected time until merged

A few days

Type of change

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (non-backwards-compatible fix or feature)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Documentation update
  • Maintenance update
  • Other (please describe)

Testing

Checklist

  • I have run flake8 and black to make sure the Python code adheres to PEP-8 and is consistently formatted
  • I have formatted the Fortran code with fprettify or C/C++ code with clang-format as applicable
  • I have run unit and regression tests which pass locally with my changes
  • I have added new tests that prove my fix is effective or that my feature works
  • I have added necessary documentation

@ewu63 ewu63 requested a review from a team as a code owner February 21, 2024 08:01
Copy link

codecov bot commented Feb 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (dbc5e37) 73.35% compared to head (276ec31) 73.35%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #385   +/-   ##
=======================================
  Coverage   73.35%   73.35%           
=======================================
  Files          22       22           
  Lines        3318     3318           
=======================================
  Hits         2434     2434           
  Misses        884      884           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@marcomangano marcomangano merged commit cae6954 into main Feb 22, 2024
13 checks passed
@marcomangano marcomangano deleted the update-paropt branch February 22, 2024 22:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ParOpt error at opt call
3 participants