-
Notifications
You must be signed in to change notification settings - Fork 109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix empty hist #399
Fix empty hist #399
Conversation
Also would appreciate a patch version bump (preferably in this PR) |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #399 +/- ##
==========================================
+ Coverage 74.10% 74.15% +0.05%
==========================================
Files 22 22
Lines 3294 3297 +3
==========================================
+ Hits 2441 2445 +4
+ Misses 853 852 -1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Can you confirm you added __all__
for linting purposes?
Yep, I believe that's a PEP8 requirement (to avoid "unused imports"). |
Purpose
If the initial evaluation fails for SNOPT, exit 61 is returned. However, this results in an empty history file with
major=True
, which errors out:This PR fixes this issue.
Expected time until merged
2 days
Type of change
Testing
Checklist
flake8
andblack
to make sure the Python code adheres to PEP-8 and is consistently formattedfprettify
or C/C++ code withclang-format
as applicable