flush streams and files before/after optimization #403
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
The idea is that,
stdout
andstderr
before calling the optimizer, in case prints from the runscript are bufferedI know we can and should do this for all optimizers, I actually tried to refactor some stuff into "pre-optimization" and "post-optimization" functions shared across all optimizers. But, I stumbled across #402 which means I couldn't actually verify what I was doing with the
dummyConstraint
was not introducing bugs. We can come back to it after that stuff is all cleaned up.Expected time until merged
Type of change
Testing
Checklist
flake8
andblack
to make sure the Python code adheres to PEP-8 and is consistently formattedfprettify
or C/C++ code withclang-format
as applicable