Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix internal host notification #17

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

bao7uo
Copy link

@bao7uo bao7uo commented Nov 6, 2020

Changed notification to config.Server.Host to match what is happening on line 55

Changed notification to config.Server.Host to match what is happening on line 55
Copy link

@yezz123 yezz123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Configure the host from host to local one?

@bao7uo
Copy link
Author

bao7uo commented Nov 24, 2020

See the internal server starts on config.Server.Host - so the listen notification message should not be hardcoded to 127.0.0.1

	server := &http.Server{
		Addr:    fmt.Sprintf("%s:%d", config.Server.Host, config.Server.InternalPort),
		Handler: route,
	}
	server.ListenAndServe()

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants