fix: clash with distinct cells and initial values from the realm

mdx-editor · Dec 27, 2023 · 9d7e57d · 9d7e57d
1 parent df98815
commit 9d7e57d
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 5 deletions.
diff --git a/src/examples.stories.tsx b/src/examples.stories.tsx
@@ -1,6 +1,11 @@
 import { Action, Cell, RealmProvider, useCellValue, useCellValues, usePublisher } from '.'
 
-const foo$ = Cell('foo')
+const foo$ = Cell('foo', (r) => {
+  r.sub(foo$, (v) => {
+    console.log('foo', v)
+  })
+})
+
 const bar$ = Cell('bar')
 
 const q$ = Action((r) => {
@@ -33,7 +38,7 @@ const WorldChild = () => {
 
 export const Hello = () => {
   return (
-    <RealmProvider>
+    <RealmProvider initWith={{ [foo$]: 'foo' }} updateWith={{ [foo$]: 'foo' }}>
       <WorldChild />
     </RealmProvider>
   )

diff --git a/src/realm.ts b/src/realm.ts
@@ -117,9 +117,9 @@ export class Realm {
   cellInstance<T>(value: T, distinct: Distinct<T> = true, node = Symbol()): NodeRef<T> {
     if (!this.state.has(node)) {
       this.state.set(node, value)
-      if (distinct !== false) {
-        this.distinctNodes.set(node, distinct === true ? defaultComparator : (distinct as Comparator<unknown>))
-      }
+    }
+    if (distinct !== false && !this.distinctNodes.has(node)) {
+      this.distinctNodes.set(node, distinct === true ? defaultComparator : (distinct as Comparator<unknown>))
     }
 
     return node as NodeRef<T>