-
-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: remark-mdx is not compatible with normal markdown syntaxes #206
Conversation
Codecov Report
@@ Coverage Diff @@
## master #206 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 19 19
Lines 411 418 +7
Branches 76 78 +2
=========================================
+ Hits 411 418 +7
Continue to review full report at Codecov.
|
This branch is not required to merge for now, but would be better to publish a |
Awesome work @JounQin! The PR is currently marked as draft. Does that mean that you‘re still working on it, and/or that it’s waiting for MDX@2? |
The fix should be compatible between v1 and v2, so I think it's ready to merge! |
// fix #4 | ||
if (isComment(value)) { | ||
const comment = COMMENT_CONTENT_REGEX.exec(value)[2] | ||
this._ast.comments.push({ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does _ast
here point to the whole ES AST? If so, it won’t work if a part but not the whole document is ignored maybe?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is only for <!-- eslint-disable ruleId -->
.
so that it could be used to disable the rule
As
remark-mdx@v2
is not compatible with normal markdown comment syntaxes anymore, so markdown and mdx files should be processed specifically.@johno @wooorm