Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for eslint 8 #353

Merged
merged 2 commits into from
Oct 18, 2021
Merged

feat: add support for eslint 8 #353

merged 2 commits into from
Oct 18, 2021

Conversation

JounQin
Copy link
Member

@JounQin JounQin commented Oct 14, 2021

No description provided.

@JounQin JounQin added 🦋 type/enhancement This is great to have 📦 area/deps This affects dependencies 🏡 area/internal This affects the hidden internals 🏗 area/tools This affects tooling 🧒 semver/minor This is backwards-compatible change labels Oct 14, 2021
@JounQin JounQin self-assigned this Oct 14, 2021
@@ -1 +1,5 @@
<!-- eslint-disable-next-line no-console -- Here's a description about why this configuration is necessary. -->
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@codesandbox-ci
Copy link

codesandbox-ci bot commented Oct 14, 2021

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@@ -44,6 +44,12 @@
"yarn-deduplicate": "^3.1.0"
},
"resolutions": {
"@typescript-eslint/eslint-plugin": "^5.0.0",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These dependencies have not been upgraded in my @1stg/eslint-config due to eslint-plugin-mdx.

@@ -63,6 +69,7 @@
"eslint/lib/linter/linter"
],
"moduleNameMapper": {
"^eslint/use-at-your-own-risk$": "<rootDir>/node_modules/eslint/lib/unsupported-api.js",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ideally it should be supported by jest itself.

@codecov-commenter
Copy link

codecov-commenter commented Oct 18, 2021

Codecov Report

Merging #353 (ee797b4) into master (24cfe78) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #353   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           21        21           
  Lines          509       515    +6     
  Branches       108       108           
=========================================
+ Hits           509       515    +6     
Impacted Files Coverage Δ
packages/eslint-plugin-mdx/src/helpers.ts 100.00% <100.00%> (ø)
...lint-plugin-mdx/src/rules/no-unused-expressions.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 24cfe78...ee797b4. Read the comment docs.

Copy link
Member

@wooorm wooorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I’m 👍 to these changes because I assume you did it correctly and I don’t see anything weird. I personally don’t know enough about ESLints to judge this though!

@JounQin
Copy link
Member Author

JounQin commented Oct 18, 2021

I've test it on my own project, so let's merge And release.

@JounQin JounQin merged commit d47af33 into master Oct 18, 2021
@JounQin JounQin deleted the feat/eslint_8 branch October 18, 2021 09:47
@JounQin
Copy link
Member Author

JounQin commented Oct 18, 2021

@wooorm Ready to release.

@JounQin
Copy link
Member Author

JounQin commented Oct 20, 2021

@wooorm Any time to release?

@wooorm
Copy link
Member

wooorm commented Oct 20, 2021

Thanks for the reminder, released!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📦 area/deps This affects dependencies 🏡 area/internal This affects the hidden internals 🏗 area/tools This affects tooling 🧒 semver/minor This is backwards-compatible change 🦋 type/enhancement This is great to have
Development

Successfully merging this pull request may close these issues.

3 participants