Certain system messages sent to other users during calculation use the "host" user's language

[mdziekon]

Description

It seems that all system messages (messages displayed using message templates and parameters stored at message creation time) which use statically created parameters using $_LANG suffer from hard-baking message pieces in just one language inherited from "host" user (the user in whom context the calculation is being made). Usually it's not a problem, but some scripts generate messages for other users as well, which might have other languages picked. One such script is Attack mission handler (MissionCaseAttack.php).

Steps to reproduce (example)

1. Find / create a user which uses different language than yourself
2. Attack that user
3. Check the attacked user's new messages (defense report message)

What should happen

• The message should consist of all pieces in the language picked by the attacked user

What actually happens

• The message consist of some pieces in the language picked by the attacking user

Regression tracking

Caused by (PR):

• N/A

Caused by (relevant code pieces):

UniEngine/includes/functions/MissionCaseAttack.php

Lines 983 to 988 in 96130dc

	$Message = false;
	$Message['msg_id'] = '075';
	$Message['args'] = array($ReportID, $ReportColor2, $FleetRow['fleet_end_galaxy'], $FleetRow['fleet_end_system'], $FleetRow['fleet_end_planet'], $TargetTypeMsg, $ReportHasHLinkRelative, $ReportHasHLinkReal);
	$Message = json_encode($Message);
	unset($DefendersIDs[0]);
	Cache_Message($DefendersIDs, 0, $FleetRow['fleet_start_time'], 3, '003', '017', $Message);

(one example)

[MickaelRod]

I'm willing to test for French if you like.

[mdziekon]

I'm willing to test for French if you like.

There's no need for that - I already know this will happen using French translation as well. This bug will happen no matter which two different languages are selected by the mentioned two users.

When I first worked on this project it only had just one translation package. Back then, I didn't need any other language, so I must have taken some shortcuts here and there, and this is the result, unfortunatelly.

[MickaelRod]

Ok.