Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Registration cleanup (part 2) #173

Merged
merged 13 commits into from
Mar 18, 2022
Merged

Registration cleanup (part 2) #173

merged 13 commits into from
Mar 18, 2022

Conversation

mdziekon
Copy link
Owner

Relates to #150 (code cleanup for further sessions refactor)

Changelog:

  • Users counter incrementing, user insertion are now moved into separate utils
  • Planet coordinate randomizer is now a separate util
  • ReCaptcha verification has been moved to a separate file
  • Referrer checking code has been moved to a separate util
  • Username & email existence checking code has been moved to a separate file
  • Fixed a bug in username & email existence checking code (one account containing both would cause error message report only the username being taken)

mdziekon added 13 commits March 16, 2022 23:42
@mdziekon
GH-150 Move incrementing the users counter to an util
2d3897d
@mdziekon
GH-150 Create helper function to get last insertion id
7f95529
@mdziekon
GH-150 Move user insertion into an util
d5109cd
@mdziekon
GH-150 Add object_map util
bec8ab9
@mdziekon
GH-150 Move planet coordinates finding into an util
945f473
@mdziekon
GH-150 Simplify checking if game is open already
4341f85
@mdziekon
GH-150 Create separate helper to get checked referrer id
27dfd37
@mdziekon
GH-150 Simplify checking referrer id in registration
1eb5811
@mdziekon
GH-150 Add some documentation regarding data sanitization
1c504a9
@mdziekon
GH-150 Move reCaptcha validator into a separate util
e2b0a7f
@mdziekon
GH-150 Load ReCaptcha lib in the validator
fb40149
@mdziekon
GH-150 Move username & email existence validation to a separate file
8c8342e
@mdziekon
GH-150 Fix email checking in case where both username & email belong …
0c83999 
…to the same account
@mdziekon mdziekon added pr:bugfix All pull requests related to fixing bugs pr:enhancement_request All pull requests related to enhancements proposals labels Mar 18, 2022
@mdziekon mdziekon merged commit 161e766 into master Mar 18, 2022
@mdziekon mdziekon deleted the mdziekon/gh-150/registration-cleanup-2 branch March 22, 2022 23:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
pr:bugfix All pull requests related to fixing bugs pr:enhancement_request All pull requests related to enhancements proposals
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@mdziekon