Registration cleanup (part 4) #175

mdziekon · 2022-03-22T02:52:00Z

Relates to #150 (code cleanup for further sessions refactor)

Changelog:

Code structure cleanup (use shortcircuits, remove mutable local vars, more sensible return format)
Create errors mapper
Fix "crowded galaxy" validation error field mapping

mdziekon added 11 commits March 22, 2022 02:07

GH-150 Move all of the reg ajax code into a function

8c8e1e8

GH-150 Add missing global vars

d69294d

GH-150 Simplify code by short circuiting

442415f

GH-150 More short circuiting

fc781a8

GH-150 Final short circuiting

1b932d5

GH-150 Pass input as arg to prevent hardcoding

35f0bfb

GH-150 Use simple returns & create separate sendResponse function

02054dd

GH-150 Limit shared variable usage when returning payload

2b78709

GH-150 Simplify messaging

b0c7f26

GH-150 Create errors mapper

e970a29

GH-150 Fix error field mapping

cb4ae9b

mdziekon added pr:bugfix All pull requests related to fixing bugs pr:enhancement_request All pull requests related to enhancements proposals labels Mar 22, 2022

mdziekon merged commit c4a6b35 into master Mar 22, 2022

mdziekon deleted the mdziekon/gh-150/registration-cleanup-4 branch March 22, 2022 23:57

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Registration cleanup (part 4) #175

Registration cleanup (part 4) #175

mdziekon commented Mar 22, 2022

Registration cleanup (part 4) #175

Registration cleanup (part 4) #175

Conversation

mdziekon commented Mar 22, 2022