Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GH-139 | Refactor flight control | FlightsList component #197

Merged
merged 42 commits into from
Apr 19, 2022
Merged

GH-139 | Refactor flight control | FlightsList component #197

merged 42 commits into from
Apr 19, 2022

Conversation

mdziekon
Copy link
Owner

@mdziekon mdziekon commented Apr 14, 2022 •
edited
Loading

Summary:

...

Changelog:

  • Displaying flights list (friendly ACS, own ACS & own regular flights) has been moved from fleet.php's code to a dedicated component, split into multiple files
  • Flights list's template files have been moved to be local to the component
  • New tests for the new flights list component (some of the code, at least)
  • Fixed a bug with incorrect "origin date" displayed for friendly union flights (destination reach time instead of original send time was displayed)
  • Fixed a bug with incorrect Union ordinal number being displayed (or no number at all, even though there is a placeholder for it)

Related issues or PRs:

@mdziekon mdziekon added the pr:refactor All pull requests containing code refactors label Apr 14, 2022
mdziekon added 14 commits April 15, 2022 02:48
@mdziekon mdziekon force-pushed the gh-139-flights-list-component branch 2 times, most recently from c1ef213 to 25f6e55 Compare April 17, 2022 00:24
@mdziekon mdziekon force-pushed the gh-139-flights-list-component branch from 25f6e55 to 27523df Compare April 17, 2022 00:28
@mdziekon mdziekon added the pr:bugfix All pull requests related to fixing bugs label Apr 18, 2022
@mdziekon mdziekon force-pushed the gh-139-flights-list-component branch from 0a51aaf to 9139909 Compare April 18, 2022 02:23
@mdziekon mdziekon marked this pull request as ready for review April 19, 2022 00:09
@mdziekon mdziekon merged commit b19777e into master Apr 19, 2022
@mdziekon mdziekon deleted the gh-139-flights-list-component branch April 19, 2022 00:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
pr:bugfix All pull requests related to fixing bugs pr:refactor All pull requests containing code refactors
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@mdziekon