Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GH-139 | Refactor flight control | Fleet sending (assorted refactors #06) #219

Merged
merged 11 commits into from
May 26, 2022
Merged

GH-139 | Refactor flight control | Fleet sending (assorted refactors #06) #219

merged 11 commits into from
May 26, 2022

Conversation

mdziekon
Copy link
Owner

Summary:

...

Changelog:

  • Parse, not just validate the fleet array
  • Move fleet counting and storage calculating code to utils
  • Reuse existing fleet array error handler
  • Do not hardcode pillageability for ships
  • Fix missing error messages for certain fleet array related cases

Related issues or PRs:

@mdziekon mdziekon added pr:bugfix All pull requests related to fixing bugs pr:refactor All pull requests containing code refactors labels May 26, 2022
@mdziekon mdziekon merged commit acce507 into master May 26, 2022
@mdziekon mdziekon deleted the gh-139-fleet-sending-assorted-refactor-06 branch May 26, 2022 00:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
pr:bugfix All pull requests related to fixing bugs pr:refactor All pull requests containing code refactors
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@mdziekon