GH-139 | Refactor flight control | Fleet sending (assorted refactors #07) #220

mdziekon · 2022-06-02T01:32:45Z

Summary:

...

Fix inadequate coordinates validation, which would allow null values in target coordinates, leading to potential SQL errors
Unification of max speed calculation
Rendering moved to separate components & utils
Move union joiner to a separate util
Simplify target coords validation at step two
Various code cleanups

mdziekon added 17 commits May 27, 2022 21:18

GH-139 Move max flight's speed getter into an util

0a7f0b0

GH-139 Simplify max speed calculation for other steps of fleet sending

edf811e

GH-139 Unify max speed calculation in galaxyfleet as well

a688604

GH-139 Move speed options renderer into a separate component

bd82c99

GH-139 Move union joining attempt calculation into an util

bb8cc7a

GH-139 Reuse same union joiner in next step

3ac44b0

GH-139 Fix coordinates validator by preventing null values from passing

bded1a0

GH-139 Use fleet missions enum more

33d9017

GH-139 Move unions list fetcher into an util

c599193

GH-139 Add documentation note about callback's expected return

d11c399

GH-139 Simplify conditions a bit

b4c1efe

GH-139 Pretty input box cleanup

4527e9b

GH-139 More code cleanups

16422d9

GH-139 Further code cleanups

481653d

GH-139 Simplify target position validation in step two

2b44c0e

GH-139 Use flight mission enum

1e63327

GH-139 Minor code cleanups

b6251a5

mdziekon added pr:bugfix All pull requests related to fixing bugs pr:refactor All pull requests containing code refactors labels Jun 2, 2022

mdziekon merged commit ab66f58 into master Jun 2, 2022

mdziekon deleted the mdziekon/gh-139/flight-control-refactor-part07 branch June 2, 2022 01:33