-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add docker support #251
Add docker support #251
Conversation
Hi @KagurazakaNyaa, thank you for your contribution! This addition will definitely greatly improve development experience for all potential contributors, myself included. Incidentally, this will also close an old issue #16, which is great. I'll try to review & test this locally during the upcoming weekend, however one thing that already comes up to my mind about this is related to the webserver you've used in the Dockerfile. Seems like you've used Apache (https://github.com/mdziekon/UniEngine/pull/251/files#diff-dd2c0eb6ea5cfc6c4bd4eac30934e2d5746747af48fef6da689e85b752f39557R1). Since I'm not really experienced with Apache, initially I was thinking about using Nginx as the base webserver for the dev environment, mostly because I'm already familiar with it and use it professionally on a day to day basis. Therefore, my question is - could you refactor your Pull Request to use Nginx instead of Apache? Locally, I've been using |
Ok, I'm using apache because it's a native tag for the |
I created a commit to use I did not directly share |
My initial review & testing of your PR shows no problems so far, however I didn't have enough time to test any places that could potentially be problematic with permissions (eg. places which save something to the drive, except for the installation script). I'd like to take some more time for testing, but overall I think it should be mergeable, once I'm done with the testing. Since I'm going on vacation in a few days, unfortunatelly this will have to wait until next week, sorry for that :( In the meantime, if you don't mind, some things could be improved (I'll leave some comment / proposals). However, none of them are show stoppers, so if you don't feel like changing them right now, I can do that myself after we merge your original proposal. Anyway, great job! |
@KagurazakaNyaa I was finally able to test your PR more thoroughly, with the most recent changes. So far, the only problems I've found seem to be non-fatal, and are related to write permissions to some of the
I haven't found other scripts that break like that, so right after fixing that (and the |
add sudo on readme
Maybe the problem with the
|
|
The error in generate_sig.php is because the target directory does not exist correctly. In a non-cross-container environment, this is not a problem. But when we need to share a volume across containers, it may have some subdirectories that do not exist, so we need to do extra processing for this situation. |
What's the current status of your work here? Does the "please don't merge" comment still apply? As far as I can tell, the previous signature generation problem has been fixed, however now it thrown an error about a missing function:
Looking at the code and the installed extensions in the Docker files, I have no clue why this is occuring, as all the necessary things are seemingly there. As for the stats calculation problem, it's still there, however the "mkdir in PHP" approach seems to work on that problem as well. |
If nothing else, I think it's ready to be merged. But I also have no clue about the problem with the |
I agree, signatures are a non-essential feature (and works fine on other environments), so merging it is still beneficial overall. I'll create a ticket for it, to be fixed in the future. As for the stats generation, that can be fixed in a separate PR as well. |
@KagurazakaNyaa PR has been merged, thank you again for your contribution! |
No description provided.