Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decrease Batch Transfer gas usage 7%, reduce contract deployment gas by 21% #144

Open
wants to merge 12 commits into
base: main
Choose a base branch
from
+65 −67
Open

Decrease Batch Transfer gas usage 7%, reduce contract deployment gas by 21% #144

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
28a50f4
reduce gas usage in the loop. Remove duplicate ownership check
tenthirtyone Jul 29, 2024
eba682f
833 batch transfers
tenthirtyone Jul 29, 2024
d98ffd7
add old cap, reduce bulk mint
tenthirtyone Jul 29, 2024
7127512
update other functions and error message
tenthirtyone Jul 29, 2024
baa6734
bump to 834 transfers
tenthirtyone Jul 29, 2024
fc47b35
skip batch time trial
tenthirtyone Jul 29, 2024
c61c54a
remove slither output file
tenthirtyone Jul 30, 2024
c34b740
update ERC721BatchTransferContract address in constants
tenthirtyone Aug 8, 2024
ec3b539
Clear _totalMintFee in withdraw (#142)
channing-magiceden Jul 30, 2024
daae03a
Add authorizedMint and whitelist Reservoir Relay EOA (#146)
channing-magiceden Aug 22, 2024
61e59bd
Set sideEffects:false in package.json (#145)
C-o-d-e-C-o-w-b-o-y Aug 23, 2024
c980590
Merge branch 'main' into fix/lower-batch-gas-usage
tenthirtyone Aug 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
add old cap, reduce bulk mint
@tenthirtyone
tenthirtyone committed Jul 29, 2024

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: B5690EEEBB952194
Verified
Learn about vigilant mode
commit d98ffd7822bb69c00f4b460a251bb1d2dfeff6e8
3 changes: 2 additions & 1 deletion test/ERC721BatchTransfer.test.ts
View file
Original file line number Diff line number Diff line change
@@ -36,7 +36,7 @@ describe('ERC721BatchTransfer', function () {

await nftContract.setApprovalForAll(transferContract.address, true);

await nftContract.mintBatch(owner.address, 5000);
await nftContract.mintBatch(owner.address, 1000);

for (let i = 0; i < 5; i++) {
const tokenOwner = await nftContract.ownerOf(i);
@@ -57,6 +57,7 @@ describe('ERC721BatchTransfer', function () {
});

it.skip('batchTransferToSingleWallet max Batch', async () => {
// old cap was 777
const batchAmount = 833;
const tx = await transferContract.batchTransferToSingleWallet(
nftContract.address,