-
-
Notifications
You must be signed in to change notification settings - Fork 751
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Lint Python code with ruff #3799
Conversation
0d9864a
to
97ceb13
Compare
This PR is stale because it has been open 45 days with no activity. |
Rebased to fix git conflicts. |
I'm a professional that uses Ruff in the workplace, I HIGHLY recommend implementing this, it has significantly improved my own quality and speed |
I'm not sure this PR is necessary; we already do this for every pull request: https://github.com/mealie-recipes/mealie/blob/mealie-next/Taskfile.yml#L106-L114 The difference between this PR and the existing workflow is that the existing workflow only looks at changes, whereas this PR blanket applies rules to the entire codebase, which makes some unnecessary changes. Can you go into more detail what issue this PR is trying to address? |
Given that ruff is superfast (1/3 second for the CPython codebase), why limit its visibility? 40 files are not yet ruff compliant which seems a shame. This PR is attempting to get all files to be ruff-compliant and ensure they stay that way even when ruff rules are upgraded. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fair enough. This might cause some merge conflicts with #3970 but that's fine
What type of PR is this?
(REQUIRED)
What this PR does / why we need it:
(REQUIRED)
Lint Python code with
ruff
to make it faster, easier to understand, and less error-prone.Which issue(s) this PR fixes:
(REQUIRED)
Special notes for your reviewer:
(fill-in or delete this section)
Testing
(fill-in or delete this section)
%
ruff check