fix: Add support for HTTPS in healthcheck #4538
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
please prepend the title with |
Caligatio
changed the title
|
@Kuchenpirat Done! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What this PR does / why we need it:
The current healthcheck is hardcoded to use "http" which causes an error - thus failing the healthcheck - if the new TLS support is used.
Which issue(s) this PR fixes:
Fixes #4537
Special notes for your reviewer:
I could have also wrapped the
requests.get()in a try/except, caught the TLS error case, and retried with TLS but thought checking for the relevant environment variables was cleaner.Testing
I substituted the proposed healthcheck.py in my TLS-enabled install and it began passing the healthcheck. I also disabled TLS support and the proposed healthcheck.py still worked.