fix: 4497 use Translation for Recipe created #4562
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey, thanks for your PR. |
|
Also you only need to add base translations to the en_US file. The rest is handled through crowdin. You can add the german translation over there as soon as the PR including the translation is merged. |
ziegenhagel
force-pushed
the
fix-4497
branch
from
b7d11a8
to
02d0c82
Compare
ziegenhagel
force-pushed
the
fix-4497
branch
from
02d0c82
to
642a1e0
Compare
ziegenhagel
force-pushed
the
fix-4497
branch
from
642a1e0
to
0f3d052
Compare
|
Thank you! I hope it's correct now. |
michael-genson
requested changes
Nov 18, 2024
|
Please provide a meaningful title to the pull request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What this PR does / why we need it:
This PR fixes untranslated timeline events in the recipe creation process. Currently, when creating a new recipe, the timeline event shows a hardcoded English message "Recipe Created" regardless of the user's selected language.
Changes made:
recipe_service.pyto use translation keyThis is the first step in fully localizing timeline events, starting with the two main languages. Additional language support will be added in follow-up PRs.
Which issue(s) this PR fixes:
Partial fix for #4497
Special notes for your reviewer:
The translation key follows the existing pattern used in recipe defaults:
recipe.recipe-defaults.ingredient-noterecipe.recipe-createdTesting
Tested by:
All existing tests pass. Translation keys are consistent with existing naming patterns.