Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Incorrect date format in Add to mealplan modal #4605

Merged
merged 3 commits into from
Nov 25, 2024

Conversation

Saireddy1369
Copy link
Contributor

@Saireddy1369 Saireddy1369 commented Nov 25, 2024

What type of PR is this?

bug

What this PR does / why we need it:

This PR resolves an issue with the date field hint in the "Add to Plan" dialog box. The hint initially displayed the date format as MM/DD/YYYY, which was inconsistent with the actual date format (YYYY-MM-DD). This inconsistency could confuse users, especially since the field is readonly and uses a date picker.

The hint has now been completely removed to simplify the UI and avoid redundancy.

Changes made:

  • Removed the :hint and persistent-hint properties from the <v-text-field> component for the date picker in the "Add to Plan" dialog box.
  • Simplified the UI by removing the unnecessary hint, as the field is not intended for manual input.

Which issue(s) this PR fixes:

Fixes #4598

Special notes for your reviewer:

  • Please verify that removing the hint does not introduce any regressions in other parts of the application.
  • Ensure that the date picker functionality works as expected across different languages and locales.

Testing:

  • Tested on the demo site using Firefox 128.4.0esr on Windows 11.
  • Verified that the hint has been successfully removed.
  • Confirmed that the date picker field remains readonly and continues to function as intended.

@michael-genson
Copy link
Collaborator

On mobile, so apologies if this is an obvious question: does the user type the date into this field manually, or do they use a date picker?

If it's a date picker, should we just get rid of the hint? I'm not sure what purpose it serves otherwise

@Saireddy1369
Copy link
Contributor Author

Yes, it's a date picker. Initially, I thought of avoiding confusion by matching the hint format with the displayed date format, so I made changes to use date-format-hint-yyyy-mm-dd.

However, I completely agree that the hint might be unnecessary since the field isn't meant for manual input. I’ll update my changes to remove the hint altogether to simplify and avoid redundancy. Thank you for pointing it out!

@Saireddy1369 Saireddy1369 changed the title Fixed incorrect date format in Add to mealplan modal fix: Incorrect date format in Add to mealplan modal Nov 25, 2024
@Saireddy1369
Copy link
Contributor Author

Updated the code to remove the date picker hint in the 'Add to Plan' dialog. The field uses a date picker, so the hint was unnecessary. Please review the changes. Thanks!

Copy link
Collaborator

@michael-genson michael-genson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@michael-genson michael-genson enabled auto-merge (squash) November 25, 2024 15:30
@michael-genson michael-genson merged commit efb72b1 into mealie-recipes:mealie-next Nov 25, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] - Date format hint is incorrect (and probably irrelevant)
2 participants