Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Development @Inject DI , bostraping fireloop-loopback app #1

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

kattsushi
Copy link

hey @jonathan-casarrubias I have been researching on the typescript decorators and I have been working to implement the idea of the other day about @Inject @bootscript https://github.com/mean-expert-official/fireloop.io/issues/22#issuecomment-262576960 and I would like to know your opinion on this pull request for the @Inject implementation, greetings!

@kattsushi kattsushi changed the title Development Development @Inject DI , bostraping fireloop-loopback app Nov 30, 2016
@jonathan-casarrubias
Copy link
Contributor

Hey @kattsushi thanks for sharing this, I will try it asap.

I just released the release candidate for the SDK Builder and the Component Realtime, now I will have more time for the fireloop part, so I think I will change the structure and keep everything within the fireloop repository.

Once I do that, I will check your code and add it into that repo.

Cheers
Jon

@kattsushi
Copy link
Author

Your welcome @jonathan-casarrubias , you said the other day of this is treated and I am glad to be part of the community and have a feedback because it helps me a lot to learn and be an expert in typescript and these amazing technologies, many congratulations for the RC of SDK tool builder I've been studying it and I know it's a great job! I hope that with the code you have an idea of what I can think of for the Inject only that for it to work with the boostraping I need to migrate the server.js to typescript and work that way to continue I hope it serves you a lot and come up with better ideas Even: D, Greetings!

@jonathan-casarrubias
Copy link
Contributor

Hey @kattsushi my friend, I just updated the fireloop.io repository structure, so we start building an actual framework, instead of having many multiple modules apart.

So, within the fireloop repository I created a decorators directory, could you migrate your code there and create the pull request in that repo.

https://github.com/mean-expert-official/fireloop.io/tree/master/decorators

Also, I want to thank you for help on answering questions within the repos that is so cool, I'm thinking that this is growing in a manner that the help is much appreciated, but also I'm thinking in start adding people as part of the team, for both code contributions and community questions.

Since you have been doing both already I want to invite you to be mean-expert member if that is ok for you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants