feat(android): handle warm launches that are lukewarm #1268
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
abhaysood
force-pushed
the
launch-tracker-improvements
branch
from
d8ee17f to
2255283
Compare
* Discard lukewarm launch from warm launch duration compute. * Log anomalous warm launch events for future improvements.
abhaysood
force-pushed
the
launch-tracker-improvements
branch
from
2255283 to
152aba7
Compare
abhaysood
changed the title
abhaysood
changed the title
abhaysood
changed the title
- update session data with a non-lukewarm warm_launch event - update validation for warm_launch event - update query for getting launch metrics - update log of anomalous warm_launch duration
detj
approved these changes
Sep 23, 2024
Update last app visible state each time instead of waiting for cold launch, otherwise, app visible uptime is always unavailable for lukewarm launch.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Improve warm launch tracking by differentiating lukewarm launches.
Schema changes
Certain warm launch events (lukewarm) were being attributed as cold launch before Attribute launch as "warm" instead of "cold", when the launched activity has saved state #1246. Now they are tracked as warm launch, but there is no way to differentiate them from a normal warm launch. Introduce a new field
warm_launch.is_lukewarmto indicate this.Add the following timings to allow calculation of lukewarm launch time in future. Currently this data will be used for studying the patterns.
warm_launch.process_start_uptimewarm_launch.process_start_requested_uptimewarm_launch.content_provider_attach_uptimeMetric calculation changes
Discard lukewarm launch events from warm_launch duration metric calculation. These will mostly be much higher than normal warm launch events and will skew the metric.
Log anomalous warm launch events
Warm launch events where:
is_lukewarm = falseandapp_visible_uptime = 0aren't expected. However, such cases might still come up in production, log such cases for future improvements.closes: #1254
closes: #1180