fix: provide empty readOnly object instead of undefined to root resol…

…veFields
measuredco · Jan 29, 2025 · 8992a94 · 8992a94
1 parent b7ff689
commit 8992a94
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 5 deletions.
diff --git a/packages/core/lib/__tests__/use-resolved-fields.spec.tsx b/packages/core/lib/__tests__/use-resolved-fields.spec.tsx
@@ -182,7 +182,7 @@ describe("use-resolved-fields", () => {
       expect(mockResolveFields).toHaveBeenCalledWith(
         {
           props: {},
-          readOnly: undefined,
+          readOnly: {},
         },
         {
           appState: {
@@ -230,7 +230,7 @@ describe("use-resolved-fields", () => {
         expect(mockResolveFields).toHaveBeenCalledWith(
           {
             props: {},
-            readOnly: undefined,
+            readOnly: {},
           },
           {
             appState: {
@@ -280,15 +280,15 @@ describe("use-resolved-fields", () => {
       expect(result.current[1]).toBe(false);
       expect(mockResolveFields).toHaveBeenCalledTimes(2);
       expect(mockResolveFields.mock.calls[1]).toEqual([
-        { props: { foo: "bar" }, readOnly: undefined },
+        { props: { foo: "bar" }, readOnly: {} },
         {
           appState: {
             data: { content: [], root: { props: { foo: "bar" } } }, // props changed
             ui: { itemSelector: null },
           },
           changed: { foo: true }, // track changed
           fields: { title: { type: "text" } },
-          lastData: { props: {}, readOnly: undefined },
+          lastData: { props: {}, readOnly: {} },
           lastFields: { title: { type: "textarea" } }, // track previous fields due to re-render
           parent: null,
         },

diff --git a/packages/core/lib/use-resolved-fields.ts b/packages/core/lib/use-resolved-fields.ts
@@ -59,7 +59,7 @@ export const useResolvedFields = (): [FieldsType, boolean] => {
     () =>
       selectedItem
         ? selectedItem
-        : { props: rootProps, readOnly: data.root.readOnly },
+        : { props: rootProps, readOnly: data.root.readOnly || {} },
     [selectedItem, rootProps, data.root.readOnly]
   );