testing PR #9
Open
testing PR #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jia Hao <[email protected]>
Signed-off-by: Kateryna Nezdolii <[email protected]>
Signed-off-by: Kateryna Nezdolii <[email protected]>
Signed-off-by: Tong Cai <[email protected]>
The underlying memcache client library allows this to be configured, and currently defaults to a value of 2, see: https://github.com/bradfitz/gomemcache/blob/master/memcache/memcache.go#L72 https://github.com/bradfitz/gomemcache/blob/master/memcache/memcache.go#L145 https://github.com/bradfitz/gomemcache/blob/master/memcache/memcache.go#L239 This allows this value to be configured by a new environmet variable: MEMCACHE_MAX_IDLE_CONNS which defaults to -1 meaning the default from the library will apply (which is the current behaviour). Signed-off-by: Peter Marsh <[email protected]>
Signed-off-by: devincd <[email protected]>
Signed-off-by: Peter Marsh <[email protected]>
- servers listen addresses are configurable via environment variable - matches port configurability providing *HOST environment variables Fixes #245 Signed-off-by: Sunjay Bhatia <[email protected]>
User deferred barrier.signal() so panic definitely occurs before we continue on in test. Config reload uses recover() and increments config load counter, tests were failing to see config load error counter increment. Fixes: #256 Signed-off-by: Sunjay Bhatia <[email protected]>
This allows MEMCAHE_SRV to be specified as an SRV record from
which multiple memcache hosts can be resolved. For example:
MEMCACHE_SRV=_memcache._tcp.mylovelydomain.com
This can be used instead of MEMCACHE_HOST_PORT.
This will then be resolved and whatever set of servers it represents
will be used as the set of memcache servers to connect to. At this
stage neither priority or weight is supported, though weight could
be fairly straightforwardly in future.
The SRV can be polled periodically for new servers by setting the
following env var (with 0 meaning "never check"):
MEMCACHE_SRV_REFRESH=600s # supports standard go durations
Signed-off-by: Peter Marsh <[email protected]>
…ve them to goroutines pool (#251) Signed-off-by: bstorozhuk <[email protected]>
Signed-off-by: Pablo Radnic <[email protected]>
Signed-off-by: lmajercak-wish <[email protected]>
Signed-off-by: devincd <[email protected]>
Signed-off-by: Yuki Sawa <[email protected]>
Signed-off-by: devincd <[email protected]>
Signed-off-by: Yuki Sawa <[email protected]>
Signed-off-by: Yuki Sawa <[email protected]>
Signed-off-by: Yuki Sawa <[email protected]>
Signed-off-by: Matt Klein <[email protected]>
Signed-off-by: Javier Ruiz Arduengo <[email protected]>
* Add configurable GrpcMaxConnectionAge, GrpcMaxConnectionAgeGrace Signed-off-by: lmajercak-wish <[email protected]> * Add configurable GrpcMaxConnectionAge, GrpcMaxConnectionAgeGrace Signed-off-by: lmajercak-wish <[email protected]> * Fix fmt Signed-off-by: lmajercak-wish <[email protected]> * Add to README Signed-off-by: lmajercak-wish <[email protected]> * Fix README format Signed-off-by: lmajercak-wish <[email protected]>
This did not work in practice due to a mix up of
func example(serverList memcache.ServerList)
and
func example(serverList *memcache.ServerList)
The code used the first case and did not correctly update a given
memcache.ServerList instance, instead a new one was created, updated
then forgot.
Signed-off-by: Peter Marsh <[email protected]>
#292) * Addressing issue #291 - Adding custom headers with the ratelimit triggered Signed-off-by: Jesper Söderlund <[email protected]> * Fixing doc format Signed-off-by: Jesper Söderlund <[email protected]> * Fixing data race condition during config-reload Signed-off-by: Jesper Söderlund <[email protected]> * Review comments Signed-off-by: Jesper Söderlund <[email protected]> * Review comments Signed-off-by: Jesper Söderlund <[email protected]> * Changed settings approach. Refactored custom clock to use already existing TimeSource Signed-off-by: Jesper Söderlund <[email protected]> * Cleanup after timesource refactoring Signed-off-by: Jesper Söderlund <[email protected]> * Fixed review comments Signed-off-by: Jesper Söderlund <[email protected]> Co-authored-by: Jesper Söderlund <[email protected]>
* Global ShadowMod Signed-off-by: Jesper Söderlund <[email protected]> * Adding shadow-mode issue #293 Signed-off-by: Jesper Söderlund <[email protected]> * Fix doc format Signed-off-by: Jesper Söderlund <[email protected]> * Extended example to showcase shadow mode as well, build a docker image with the current rate limit, extend envoy config to display rate limit headers. Extend statsd to show shadow mode Signed-off-by: Jesper Söderlund <[email protected]> * Fine tuning of docs and example Signed-off-by: Jesper Söderlund <[email protected]> * Added integration tests, fixed some review comments Signed-off-by: Jesper Söderlund <[email protected]> * Doc format fix Signed-off-by: Jesper Söderlund <[email protected]> * gitignore for vscode Signed-off-by: Jesper Söderlund <[email protected]> Co-authored-by: Jesper Söderlund <[email protected]>
* Add pre-commit linters, formatters Signed-off-by: Yuki Sawa <[email protected]> * add descriptive name for fail msg step Signed-off-by: Yuki Sawa <[email protected]> * shorten precommit makefile cmd Signed-off-by: Yuki Sawa <[email protected]> * make fix_format Signed-off-by: Yuki Sawa <[email protected]> * autoformat all lint errs Signed-off-by: Yuki Sawa <[email protected]> * backtick quote to avoid formatter Signed-off-by: Yuki Sawa <[email protected]> * add shfmt for bash linting Signed-off-by: Yuki Sawa <[email protected]>
* Do not panic on debug /rlconfig if no config loaded Signed-off-by: James Fish <[email protected]> * Format Signed-off-by: James Fish <[email protected]> * Collapse if Signed-off-by: James Fish <[email protected]>
Signed-off-by: debbyku <[email protected]>
Signed-off-by: Peter Marsh <[email protected]>
* health check failed if no active redis connection Signed-off-by: debbyku <[email protected]> * solve redis connection active count error Signed-off-by: debbyku <[email protected]>
redis client is never closed, even after graceful shutdown. It is possible to observe this by creating a runner, and calling Stop(), and stopping redis. Runner is expected to be stopped, and all components closed, however still logs can be seen that redis is unavailable. this patch allows runner to actually gracefully close rate limit implementations, so all components are closed gracefully on Stop. Signed-off-by: Johannes Brüderl <[email protected]>
Signed-off-by: Janis Meybohm <[email protected]>
…639) Bumps [go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracegrpc](https://github.com/open-telemetry/opentelemetry-go) from 1.27.0 to 1.28.0. - [Release notes](https://github.com/open-telemetry/opentelemetry-go/releases) - [Changelog](https://github.com/open-telemetry/opentelemetry-go/blob/main/CHANGELOG.md) - [Commits](open-telemetry/opentelemetry-go@v1.27.0...v1.28.0) --- updated-dependencies: - dependency-name: go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracegrpc dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…#647) Bumps golang from 1.22.4 to 1.22.5. --- updated-dependencies: - dependency-name: golang dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: zirain <[email protected]>
Bumps golang from `fcae9e0` to `86a3c48`. --- updated-dependencies: - dependency-name: golang dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [google.golang.org/grpc](https://github.com/grpc/grpc-go) from 1.64.0 to 1.65.0. - [Release notes](https://github.com/grpc/grpc-go/releases) - [Commits](grpc/grpc-go@v1.64.0...v1.65.0) --- updated-dependencies: - dependency-name: google.golang.org/grpc dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…pc/otelgrpc (#672) Bumps [go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc](https://github.com/open-telemetry/opentelemetry-go-contrib) from 0.52.0 to 0.53.0. - [Release notes](https://github.com/open-telemetry/opentelemetry-go-contrib/releases) - [Changelog](https://github.com/open-telemetry/opentelemetry-go-contrib/blob/main/CHANGELOG.md) - [Commits](open-telemetry/opentelemetry-go-contrib@zpages/v0.52.0...zpages/v0.53.0) --- updated-dependencies: - dependency-name: go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [actions/upload-artifact](https://github.com/actions/upload-artifact) from 4.3.4 to 4.3.6. - [Release notes](https://github.com/actions/upload-artifact/releases) - [Commits](actions/upload-artifact@0b2256b...834a144) --- updated-dependencies: - dependency-name: actions/upload-artifact dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps golang from 1.22.5 to 1.22.6. --- updated-dependencies: - dependency-name: golang dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps golang from 1.22.5 to 1.22.6. --- updated-dependencies: - dependency-name: golang dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [github/codeql-action](https://github.com/github/codeql-action) from 3.25.15 to 3.26.0. - [Release notes](https://github.com/github/codeql-action/releases) - [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md) - [Commits](github/codeql-action@afb54ba...eb055d7) --- updated-dependencies: - dependency-name: github/codeql-action dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [actions/setup-go](https://github.com/actions/setup-go) from 5.0.1 to 5.0.2. - [Release notes](https://github.com/actions/setup-go/releases) - [Commits](actions/setup-go@cdcb360...0a12ed9) --- updated-dependencies: - dependency-name: actions/setup-go dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [docker/setup-buildx-action](https://github.com/docker/setup-buildx-action) from 3.5.0 to 3.6.1. - [Release notes](https://github.com/docker/setup-buildx-action/releases) - [Commits](docker/setup-buildx-action@aa33708...988b5a0) --- updated-dependencies: - dependency-name: docker/setup-buildx-action dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [ossf/scorecard-action](https://github.com/ossf/scorecard-action) from 2.3.3 to 2.4.0. - [Release notes](https://github.com/ossf/scorecard-action/releases) - [Changelog](https://github.com/ossf/scorecard-action/blob/main/RELEASE.md) - [Commits](ossf/scorecard-action@dc50aa9...62b2cac) --- updated-dependencies: - dependency-name: ossf/scorecard-action dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: zirain <[email protected]>
Bumps alpine from 3.20.2 to 3.20.3. --- updated-dependencies: - dependency-name: alpine dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps alpine from `0a4eaa0` to `1e42bbe`. --- updated-dependencies: - dependency-name: alpine dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps alpine from `beefdbd` to `1e42bbe`. --- updated-dependencies: - dependency-name: alpine dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps golang from 1.22.6 to 1.23.3. --- updated-dependencies: - dependency-name: golang dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps golang from 1.22.6 to 1.23.3. --- updated-dependencies: - dependency-name: golang dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [github/codeql-action](https://github.com/github/codeql-action) from 3.26.0 to 3.27.5. - [Release notes](https://github.com/github/codeql-action/releases) - [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md) - [Commits](github/codeql-action@eb055d7...f09c1c0) --- updated-dependencies: - dependency-name: github/codeql-action dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps golang from `d56c3e0` to `73f06be`. --- updated-dependencies: - dependency-name: golang dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps golang from `d56c3e0` to `73f06be`. --- updated-dependencies: - dependency-name: golang dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: zirain <[email protected]>
Bumps [actions/setup-python](https://github.com/actions/setup-python) from 5.1.1 to 5.3.0. - [Release notes](https://github.com/actions/setup-python/releases) - [Commits](actions/setup-python@39cd149...0b93645) --- updated-dependencies: - dependency-name: actions/setup-python dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: zirain <[email protected]>
Signed-off-by: Rico Pahlisch <[email protected]> Signed-off-by: Rico Pahlisch <[email protected]>
* 365 days in a year, not 356 Signed-off-by: Arko Dasgupta <[email protected]>
Signed-off-by: zirain <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.