Add new flexible parameters and new logic of using of nominatim-docker #394
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
| @@ -66,7 +70,7 @@ sudo -E -u postgres psql postgres -tAc "SELECT 1 FROM pg_roles WHERE rolname='ww | |||
| sudo -E -u postgres psql postgres -tAc "ALTER USER nominatim WITH ENCRYPTED PASSWORD '$NOMINATIM_PASSWORD'" && \ | |||
| sudo -E -u postgres psql postgres -tAc "ALTER USER \"www-data\" WITH ENCRYPTED PASSWORD '${NOMINATIM_PASSWORD}'" && \ | |||
|
|
|||
| sudo -E -u postgres psql postgres -c "DROP DATABASE IF EXISTS nominatim" | |||
| sudo -E -u postgres psql postgres -c "DROP DATABASE IF EXISTS $PGDATABASE" | |||
There was a problem hiding this comment.
I'm wondering why we even drop the database in the first place. Seems quite destructive.
@philipkozeny do you have an idea?
There was a problem hiding this comment.
@leonardehrenfried because the OG maintainer started doing that in the initial version he released, never questioned if we should continue with that behaviour to be honest ...
nominatim-docker/2.5/Dockerfile
Line 50 in 10fc9e4
There was a problem hiding this comment.
That because I try to make it safely.
It's OK, if you could change name, I think
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When I made these changes, my goal was:
To do this, I added:
SKIP_IMPORT, which allows skipping imports when we have a "naive" container that is intended only for updatingPGDATABASEto the documentation and change a few lines in which thenominatimdatabase participates in order to avoid erroneous database deletion on production systemsThank you for your work