Update mediahub-dev to r2.19.1 #4
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This setting is buggy on some devices (for example sm-n960f) PiperOrigin-RevId: 529712770
Minimal fix for HDR test postsubmit breakage PiperOrigin-RevId: 529734521
#minor-release PiperOrigin-RevId: 529742339
#minor-release PiperOrigin-RevId: 529743667
`VERSION_INT` is quite long with several sections, and it's easy to make a mistake when updating it - this should help since it checks it against `VERSION`, which is more easily human readable/writable. PiperOrigin-RevId: 529747023
For DefaultVideoFrameProcessorVideoFrameRenderingTest: `registerInputStream` sets the textureManager, so reordering makes sure the textureManager is set before you set the frame info. This is important for texture input, where the frame info provides the width and height. PiperOrigin-RevId: 529753404
PiperOrigin-RevId: 530314222
Adding items to an empty playlist is slightly different from adding items to a non-empty playlist, because the former usually requires to handle a change in the current item, position and playback state, while the latter is not expected to affect the current item, position or state. The current ExoPlayer and SimpleBasePlayer code doesn't account for this difference, leading to inconsistent behavior between setMediaItem(s) and addMediaItem(s) when called on an empty playlist. PiperOrigin-RevId: 530549928
PiperOrigin-RevId: 530578549
similar error to google@2c4a567c74088c639d699eeefe139c38e254e230L `registerInputStream` sets the textureManager, so reordering makes sure the textureManager is set before you set the frame info. This is important for texture input, where the frame info provides the width and height. PiperOrigin-RevId: 530579584
If tone-mapping was requested for a device supporting HDR encoding, isToneMapped was false in VideoSamplePipeline.EncoderWrapper. This was causing the encoder to expect HDR. Also did some renamings to improve readability PiperOrigin-RevId: 530584010
Allow use of H265/H264 codecs for Dolby Vision video. Also, reflow ExoPlayer code to use this new utility class PiperOrigin-RevId: 530619388
PiperOrigin-RevId: 530624195
Exceptions thrown when switching AssetLoader were not reported through the error listener. Therefore, the resources were not released and the export was not ending. PiperOrigin-RevId: 530626300
Tone-mapping an HDR video with MediaCodec on sm-s908u1 was timing out. The reason for that is that the decoder was dropping frames, and the ExternalTextureManager was therefore never propagating the end-of-stream signal. There was already a workaround for a similar issue but restricted to sm-f936b. Removed the model check as the bug is probably present on more devices. PiperOrigin-RevId: 530639437
Verified by running all the tests in mh (excluding the analysis tests) on a pixel 7 pro PiperOrigin-RevId: 530655237
To use the InAppMuxer, the client needs to pass InAppMuxer Factory. PiperOrigin-RevId: 530684007
PiperOrigin-RevId: 530711523
PiperOrigin-RevId: 530878135
PiperOrigin-RevId: 530888319
#minor-release PiperOrigin-RevId: 530935437
*** Original commit *** Create InAppMuxer in transformer To use the InAppMuxer, the client needs to pass InAppMuxer Factory. *** PiperOrigin-RevId: 531056436
Find and replace "mime" to "MIME", where appropriate, throughout media3. PiperOrigin-RevId: 531122121
PiperOrigin-RevId: 531123743
The texture input tests in TransformerEndToEndTest were not passing on Pixel 7. Implemented a fix and fixed other minor threading issues I spotted while looking at the code. PiperOrigin-RevId: 531141659
PiperOrigin-RevId: 531180020
This change adds end-to-end Robolectric playback tests which handle the scenario the player is playing audio via passthrough and AudioTrack raises the ERROR_DEAD_OBJECT error upon which the player attempts to recover by switching to another audio format. PiperOrigin-RevId: 531180183
PiperOrigin-RevId: 531193242
PiperOrigin-RevId: 531233480
This was added in google@75cde0a but was accidentally exported to the exoplayer2 GitHub repo (where `MediaLibraryInfo` is not present). #minor-release PiperOrigin-RevId: 531235570
#minor-release PiperOrigin-RevId: 546803592 (cherry picked from commit db1efe6)
Added these CMCD-Session fields to Common Media Client Data (CMCD) logging. #minor-release PiperOrigin-RevId: 547435498 (cherry picked from commit d82a86f)
`Dummy` is a non inclusive language. PiperOrigin-RevId: 547815680 (cherry picked from commit 74c3ae2)
PiperOrigin-RevId: 548063325 (cherry picked from commit e1d5c68)
Added tests for Common Media Client Data (CMCD) logging in SmoothStreaming(SS) PiperOrigin-RevId: 548072725 (cherry picked from commit bc8f553)
Add Ogg ID Header and Comment Header Pages to the Ogg encapsulated Opus for offload playback. This further matches the RFC 7845 spec and provides initialization data to decoders. PiperOrigin-RevId: 548080222 (cherry picked from commit 4c894aa)
The streams return end-of-input if they read no samples, but know that they are fully buffered to at least the clipped end time. This helps to detect the end of stream even if there are no new buffers after the end of the clip (e.g. for sparse metadata tracks). The race condition occurs because the buffered position is evaluated after reading the sample. So between reading "no sample" and checking the buffered position, the source may have loaded arbitrary amounts of data. This may lead to a situation where the source has not read all samples, reads NOTHING_READ (because the queue is empty) and then immediately returns end-of-stream (because the buffered position jumped forward), causing all remaining samples in the stream to be skipped. This can fixed by moving the buffered position check to before reading the sample, so that it never exceeds the buffered position at the time of reading "no sample". #minor-release PiperOrigin-RevId: 548646464 (cherry picked from commit b3a7ff9)
Added these CMCD-Object fields to Common Media Client Data (CMCD) logging. #minor-release PiperOrigin-RevId: 548950296 (cherry picked from commit 43fc921)
Updated `ExoTrackSelection` to provide the most recent bitrate estimate, enabling the inclusion of measured throughput (mtp) as a CMCD-Request field in Common Media Client Data (CMCD) logging. Additionally, made changes to the `checkArgument` methods in `CmcdLog` to prevent the use of default values in certain cases. #minor-release PiperOrigin-RevId: 549369529 (cherry picked from commit 7969618)
This code is Widevine specific. `OfflineLicenseHelper.downloadLicense` requires the passed `Format` to have a `DrmInitData.SchemeData` with Widevine UUID and non-null `data` field. The demo app tries to check this in advance (to avoid an exception later), but its checks are looser than those made by `OfflineLicenseHelper`. This change tightens the checks to match. Issue: androidx/media#512 PiperOrigin-RevId: 549587506 (cherry picked from commit b7988e2)
PiperOrigin-RevId: 550596173 (cherry picked from commit 2a53b52)
The current code multiplies the value by 1000 twice, effectively converting to nanoseconds. #minor-release PiperOrigin-RevId: 551129750 (cherry picked from commit f6f86fd)
Fix short term reference picture list parsing. Before this change, `deltaPocS0` was derived by adding one to the value of the syntax element `delta_poc_s0_minus1`, but (maybe surprising) the specification actually says that `DeltaPocS0[stRpsIdx][i]` should be assigned the negation `-(delta_poc_s0_minus1[i] + 1)` on the first iteration, then that value added to the previous value on previous iterations. See equations (7-67) to (7-70) in the 2021-08 version of the H.265/HEVC specification. Also read the number of long term reference pictures once rather than on every loop iteration (subsection 7.3.2.2.1). PiperOrigin-RevId: 551852999 (cherry picked from commit 2fe6726)
#minor-release PiperOrigin-RevId: 552749407 (cherry picked from commit ed071ab)
Refactored `CmcdLog` to `CmcdHeadersFactory` for improved representation of its purpose and updated implementations. #minor-change PiperOrigin-RevId: 552831995
PiperOrigin-RevId: 554439196 (cherry picked from commit 5984b07)
#minor-release PiperOrigin-RevId: 554451569 (cherry picked from commit 2063db1)
This fixes a bug with playing very short audio files, introduced by google@fe71087 The existing code using floor integer division results in playback never transitioning to `STATE_ENDED` because at the end of playback for the short sample clip provided `currentPositionUs=189937`, `outputSampleRate=16000` and `(189937 * 16000) / 1000000 = 3038.992`, while `writtenFrames=3039`. This is fixed by using `Util.ceilDivide` so we return `3039`, which means `AudioTrackPositionTracker.hasPendingData()` returns `false` (since `writtenFrames == durationUsToFrames(getCurrentPositionUs(/* sourceEnded= */ false))`). Issue: androidx/media#538 PiperOrigin-RevId: 554481782 (cherry picked from commit a9a2451)
Added this CMCD-Object field to Common Media Client Data (CMCD) logging. #minor-release PiperOrigin-RevId: 554843305 (cherry picked from commit f11106c)
#minor-change PiperOrigin-RevId: 555130308 (cherry picked from commit afccebb)
Gradle Lint doesn't recognise `checkState` assertion and TargetApi should only ever be used for suppressing a bug in Android Lint. Hence, we keep @RequiresApi and add an if-statement explicitly. Also, fixes >26 to >=26 for the version check. PiperOrigin-RevId: 555144577 (cherry picked from commit 5720b61)
PiperOrigin-RevId: 554869426 (cherry picked from commit 7e35472)
Updates to the ad playback state are posted on the main handler, so they may arrive after the source has already been released (=the internal MediaSource is null). This can cause NPEs. PiperOrigin-RevId: 555102426 (cherry picked from commit eb0e7ac)
This flag was introduced to fix links in javadoc search when generating it with Java 11: <unknown commit> The flag is no longer supported with Java 17 (which is required for Gradle 8.0+), and seems to no longer be needed: I generated the javadoc with it removed and the search links work OK. PiperOrigin-RevId: 536738686
1. Not treating 0 as valid buffer index 2. Not handling the case the last frame is a comparison frame PiperOrigin-RevId: 539607482 (cherry picked from commit 7509887)
PiperOrigin-RevId: 555948664 (cherry picked from commit 5501f13)
PiperOrigin-RevId: 555956086 (cherry picked from commit f37f792)
PiperOrigin-RevId: 555987303 (cherry picked from commit 0a62b34)
#minor-release PiperOrigin-RevId: 558098987 (cherry picked from commit 10748c3)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.