Advanced FFMpeg configuration: Hardware acceleration, codec and quality choice. #1485
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@AntonIXO is attempting to deploy a commit to the louis030195's projects Team on Vercel. A member of the Team first needs to authorize it. |
louis030195
reviewed
Feb 26, 2025
| @@ -81,6 +86,11 @@ export function DataImportSection() { | |||
| creation_time: new Date().toISOString(), | |||
| fps: 30, | |||
| device_name: "", | |||
| video_codec: "", | |||
There was a problem hiding this comment.
does the add cli uses these settings?
louis030195
reviewed
Feb 26, 2025
| @@ -900,7 +920,129 @@ export function RecordingSettings() { | |||
| </div> | |||
| </div> | |||
|
|
|||
| {/* */} | |||
| <div className="flex flex-col space-y-4"> | |||
There was a problem hiding this comment.
i wonder if we can make the UI more scalable, like, most people don't want to bother with those, so maybe a advanced setting part or idk
There was a problem hiding this comment.
Moved down to an advanced settings menu
|
I had to merge Wayland fix also to test changes |
|
@louis030195 Do you have plans to merge it? Made changes to settings and moved it to an advanced menu. Wayland fix seems not needed anymore. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
name: Advanced FFMpeg configuration: Hardware acceleration, codec and quality choice.
description
Added the ability to change codec, enable hardware acceleration and change quality.
how to test