fix changelog generation #648
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
ologbonowiwi
commented
Nov 7, 2024
ologbonowiwi
commented
- improve docs (only adding stuff to fake a commit for changelog)
- Revert "improve docs (only adding stuff to fake a commit for changelog)"
- fix: use crab nebula to get last version instead of git tags
- ci: use version from user input on release
- ci: only change the pipeline when changelog is generated
- docs: rollback old changelog
- refactor: remove unnecessary variable and use commit hashes on changelog diff
- refactor: show only first 5 chars from commits
- fix: download crab nebula cli before using it
- chore: only download cn if does not exist
- chore: delete broken version
- refactor: tweaks on changelog generator
This reverts commit ebf8b5f7c03d00ef6a467f34120cbb640a81d3df.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
ologbonowiwi
commented
Nov 7, 2024
|
|
||
| # Add the full changelog on the end of the file | ||
| echo """ | ||
| #### **Full Changelog:** [$LAST_RELEASE...$CURRENT_RELEASE](https://github.com/mediar-ai/screenpipe/compare/$LAST_RELEASE...$CURRENT_RELEASE) | ||
| #### **Full Changelog:** [$SHORT_COMMIT_LAST_RELEASE..$SHORT_COMMIT_CURRENT_RELEASE](https://github.com/mediar-ai/screenpipe/compare/$SHORT_COMMIT_LAST_RELEASE..$SHORT_COMMIT_CURRENT_RELEASE) | ||
| """ >> content/changelogs/$CURRENT_RELEASE.md |
There was a problem hiding this comment.
This works but note that if have multiple versions, it'll work fine but the specific changelog for that version will be overwritten. is that ok @louis030195?
if we need to keep all changelogs from all versions – even duplicates – it'll require a few tweaks but I can implement it. I'll basically add timestamp to the changelog name, so we can differentiate between them. if it's ok override the duplicated version, feel free to merge it (unless you have any comments)
* Use self-hosted runner for release app * Use preinstalled Ollama * Fix ffmpeg path * Rename ollama and use sourceforge for macos * Fix ffmpeg path * Use bin for ffmpeg path
|
@ologbonowiwi can you fix conflict & i merge? |
This reverts commit ebf8b5f7c03d00ef6a467f34120cbb640a81d3df.
…owiwi/screenpipe into fix-changelog-generation
ologbonowiwi
commented
Nov 7, 2024
There was a problem hiding this comment.
rollbacking to the old version. shouldn't matter, as soon as you merge feel free to trigger a release so we can see if it works
|
conflicts fixed @louis030195 |
|
thanks a lot! |
m13v
pushed a commit
to m13v/screen-pipe
that referenced
this pull request
Nov 9, 2024
* improve docs (only adding stuff to fake a commit for changelog) * Revert "improve docs (only adding stuff to fake a commit for changelog)" This reverts commit ebf8b5f7c03d00ef6a467f34120cbb640a81d3df. * fix: use crab nebula to get last version instead of git tags * ci: use version from user input on release * ci: only change the pipeline when changelog is generated * docs: rollback old changelog * refactor: remove unnecessary variable and use commit hashes on changelog diff * refactor: show only first 5 chars from commits * fix: download crab nebula cli before using it * chore: only download cn if does not exist * chore: delete broken version * refactor: tweaks on changelog generator * refactor: delete unnecessary prompt * refactor: use commit_hash as second parameter * refactor: improve prompt * Update README.md * Revert ffmpeg in macOS to old mirror, rename ollama (mediar-ai#650) * Use self-hosted runner for release app * Use preinstalled Ollama * Fix ffmpeg path * Rename ollama and use sourceforge for macos * Fix ffmpeg path * Use bin for ffmpeg path * docs: add changelog for * improve docs (only adding stuff to fake a commit for changelog) * Revert "improve docs (only adding stuff to fake a commit for changelog)" This reverts commit ebf8b5f7c03d00ef6a467f34120cbb640a81d3df. * fix: use crab nebula to get last version instead of git tags * ci: use version from user input on release * ci: only change the pipeline when changelog is generated * docs: rollback old changelog * refactor: remove unnecessary variable and use commit hashes on changelog diff * refactor: show only first 5 chars from commits * fix: download crab nebula cli before using it * chore: only download cn if does not exist * chore: delete broken version * refactor: tweaks on changelog generator * refactor: delete unnecessary prompt * refactor: use commit_hash as second parameter * refactor: improve prompt * ci: fix generate changelog prompt --------- Co-authored-by: Louis Beaumont <[email protected]> Co-authored-by: Neptune <[email protected]> Co-authored-by: GitHub Actions Bot <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.