HTTP Checks : add a check box to control whether Cabot should follow …

…redirects

fix arachnys#20

- The setting is per-check
- default is 'checked' which means Cabot does follow redirects (as before this change)

- [x] db migration
- [x] views
- [x] REST api

cabot/cabotapp/migrations/0008_statuscheck_follow_redirects.py

@@ -0,0 +1,20 @@
+# -*- coding: utf-8 -*-
+# Generated by Django 1.11.11 on 2019-06-11 10:26
+from __future__ import unicode_literals
+
+from django.db import migrations, models
+
+
+class Migration(migrations.Migration):
+
+    dependencies = [
+        ('cabotapp', '0007_statuscheckresult_consecutive_failures'),
+    ]
+
+    operations = [
+        migrations.AddField(
+            model_name='statuscheck',
+            name='follow_redirects',
+            field=models.BooleanField(default=True, help_text=b'Uncheck to prevent Cabot from following HTTP redirections (default True)'),
+        ),
+    ]

cabot/cabotapp/models/base.py

@@ -502,6 +502,10 @@ class StatusCheck(PolymorphicModel):
         default=True,
         help_text='Set to false to allow not try to verify ssl certificates (default True)',
     )
+    follow_redirects = models.BooleanField(
+        default=True,
+        help_text='Uncheck to prevent Cabot from following HTTP redirections (default True)',
+    )
 
     # Jenkins checks
     max_queued_build_time = models.IntegerField(
@@ -769,6 +773,7 @@ def _run(self):
                 timeout=self.timeout,
                 verify=self.verify_ssl_certificate,
                 auth=auth,
+                allow_redirects=self.follow_redirects,
                 headers={
                     "User-Agent": settings.HTTP_USER_AGENT,
                 },

cabot/cabotapp/tests/tests_basic.py

@@ -788,6 +788,7 @@ def setUp(self):
                     'name': u'HTTP Check',
                     'active': True,
                     'importance': u'CRITICAL',
+                    'follow_redirects': True,
                     'frequency': 5,
                     'debounce': 0,
                     'endpoint': u'http://arachnys.com',
@@ -875,6 +876,7 @@ def setUp(self):
                     'name': u'posted http check',
                     'active': True,
                     'importance': u'ERROR',
+                    'follow_redirects': True,
                     'frequency': 5,
                     'debounce': 0,
                     'endpoint': u'http://arachnys.com/post_tests',

cabot/cabotapp/views.py

@@ -241,6 +241,7 @@ class Meta:
             'password',
             'text_match',
             'status_code',
+            'follow_redirects',
             'timeout',
             'verify_ssl_certificate',
             'frequency',

cabot/rest_urls.py

@@ -103,8 +103,9 @@ class ViewSet(viewset_class):
         'password',
         'text_match',
         'status_code',
+        'follow_redirects',
         'timeout',
-        'verify_ssl_certificate',
+        'verify_ssl_certificate'
     ),
 ))