Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: refactor edit-contacts code to reduce complexity #641

Merged
merged 5 commits into from
Nov 13, 2024
Merged

chore: refactor edit-contacts code to reduce complexity #641

merged 5 commits into from
Nov 13, 2024

Conversation

jkuester
Copy link
Contributor

@jkuester jkuester commented Nov 5, 2024 •
edited
Loading

Description

Refactoring that is the result of discussions from the Dev Workshops. No functionality should be affected by these changes.

Code review items

  • Readable: Concise, well named, follows the style guide, documented if necessary.
  • Documented: Configuration and user documentation on cht-docs
  • Tested: Unit and/or integration tests where appropriate
  • Backwards compatible: Works with existing data and configuration. Any breaking changes documented in the release notes.

License

The software is provided under AGPL-3.0. Contributions to this project are accepted under the same license.

@jkuester jkuester marked this pull request as ready for review November 5, 2024 23:37
tatilepizs
tatilepizs approved these changes Nov 12, 2024
View reviewed changes
Copy link

@tatilepizs tatilepizs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@jkuester jkuester merged commit da017f9 into main Nov 13, 2024
7 checks passed
@jkuester jkuester deleted the dev-workshop_edit-contacts branch November 13, 2024 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tatilepizs tatilepizs tatilepizs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jkuester @tatilepizs