Animated service submenu #96
Conversation
# Conflicts: # assets/_globalCss.css # components/UI/ServiceSubmenu.js # components/layouts/iframe.js # package-lock.json # package.json
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| { value && ActionComponent } | ||
| </Submenu> | ||
| ) } | ||
| </Icon> } |
Check failure
Code scanning / ESLint
Enforce consistent indentation Error
| </Submenu> | ||
| ) } | ||
| </Icon> } | ||
| </ToggleButton>} |
Check failure
Code scanning / ESLint
Enforce or disallow spaces inside of curly braces in JSX attributes and expressions Error
|
The transition is a bit wonky, but in general I like it. This is (or was) already done in other branches, but the open menu button should be replaced with a close menu button after opening the menu. Also, I’d argue it would be nice if we could click anywhere below the last menu item to close the menu? |
|
Alright, will refine on those points when I find the time. Thanks for the first check. 👀 |
|
😙👌 |
@andirueckel @marcel-klasse
Can you give this a look on your computers and tell me what you think?
Check what happens when you open/close the service submenus in /write or /sketch.