Adding a default template label #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michael Shitrit <[email protected]>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mshitrit The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
clobrano
reviewed
Nov 7, 2023
pkg/labels/labels.go
Outdated
| @@ -7,4 +7,6 @@ const ( | |||
| MasterRole = "node-role.kubernetes.io/master" | |||
| // ControlPlaneRole is the new role label of control plane nodes | |||
| ControlPlaneRole = "node-role.kubernetes.io/control-plane" | |||
| // DefaultTemplate is a label that would be set in case a remediator may have several remediation templates in order to signal to the UI which one is the default | |||
There was a problem hiding this comment.
Good idea to have the label in common.
I'd like to come up with a shorter description. What do you think about something like the following?
DefaultTemplate label indicates to third party tools (e.g. UI) the default remediation template in case several exists.
Signed-off-by: Michael Shitrit <[email protected]>
|
/lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ECOPROJECT-1759
ATM The UI is looking for SNR Template with the default remediation strategy completely hard coded (i.e hard coded for ResourceDeletion).
In order to make the UI more robust and prevent unnecessary changes in the UI when the default Strategy is changed, we'd put a label on the Template with the default strategy instead.