Add Processing Condition labels #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/lgtm |
clobrano
force-pushed
the
add-processing-and-succeeding-condition-type-labels
branch
from
ce00bf2
to
e93c61a
Compare
mshitrit
reviewed
Jul 12, 2023
pkg/labels/labels.go
Outdated
| // SucceededConditionType is the condition type used to signal whether the remediation was successful or not | ||
| SucceededConditionType = "Succeeded" | ||
| // NhcTimeOutAnnotation is the annotation set by NHC to signal the operator that it surpassed its timeout and shall stop its remediation | ||
| NhcTimeOutAnnotation = "remediation.medik8s.io/nhc-timed-out" |
There was a problem hiding this comment.
- think it would be better to put in another pkg (i.e annotations)
- Assuming we do so get rid of the "Annotation" suffix in the var name
There was a problem hiding this comment.
ah, I've been too fast, you're right
Signed-off-by: Carlo Lobrano <[email protected]>
clobrano
force-pushed
the
add-processing-and-succeeding-condition-type-labels
branch
from
e93c61a
to
977b2e8
Compare
|
/lgtm |
|
missed this. Why are the condition types in labels.go? 🤔 @clobrano |
|
I think I considered What could be a good name for the right package? |
|
just |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Carlo Lobrano [email protected]