Cleanup and prepare Openshift CI #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
slintes
commented
Jul 25, 2023
slintes
commented
- Reorg Makefile:
- add build target
- add lint target: runs all except build and unit test
- replace fmt with goimports (it's a superset)
- remove vendor related targets (doesn't make sense for a library)
- Update github workflow for updated Make targets
- Delete vendor dir
- Add build root image config file for OpenShift CI
- add build target - add lint target: runs all except build and unit test - replace fmt with goimports (it's a superset) - remove vendor (doesn't make sense for a library)
Does not make sense for libraries
mshitrit
reviewed
Jul 25, 2023
| @@ -49,17 +56,10 @@ vet: ## Run go vet against code. | |||
| verify-no-changes: ## verify there are no un-staged changes | |||
| ./hack/verify-diff.sh | |||
|
|
|||
| .PHONY:vendor | |||
There was a problem hiding this comment.
Is vendoring happens in a different job now ?
(I assume it should, but I couldn't figure out where)
There was a problem hiding this comment.
I removed vendoring completely, doesn't make sense for a library. See PR description and commit messages. The using component vendors everything.
|
/lgtm
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.