Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use new SNR labels #227

Merged
merged 1 commit into from
Aug 3, 2023

Conversation

mshitrit
Copy link
Member

@mshitrit mshitrit commented Jul 18, 2023

This PR dependent on SNR PR: medik8s/self-node-remediation#133
and E2E expect to pass only after it's merged
Corrections: looks like e2e test pass before medik8s/self-node-remediation#133 was merged - probably due to skipping some tests when not running on OCP

Signed-off-by: Michael Shitrit <[email protected]>
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 18, 2023

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@mshitrit
Copy link
Member Author

/test ?

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 18, 2023

@mshitrit: The following commands are available to trigger required jobs:

  • /test 4.11-ci-bundle-my-bundle
  • /test 4.11-images
  • /test 4.11-openshift-e2e
  • /test 4.11-test
  • /test 4.12-ci-bundle-my-bundle
  • /test 4.12-images
  • /test 4.12-openshift-e2e
  • /test 4.12-test
  • /test 4.13-ci-bundle-my-bundle
  • /test 4.13-images
  • /test 4.13-openshift-e2e
  • /test 4.13-test
  • /test 4.14-ci-bundle-my-bundle
  • /test 4.14-images
  • /test 4.14-openshift-e2e
  • /test 4.14-test

Use /test all to run all jobs.

In response to this:

/test ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mshitrit
Copy link
Member Author

/test 4.13-openshift-e2e

@mshitrit mshitrit changed the title [WIP] use new SNR labels use new SNR labels Jul 19, 2023
@razo7
Copy link
Member

razo7 commented Jul 23, 2023

/lgtm
I am adding hold until medik8s/self-node-remediation#133 will be merged
/hold

Copy link
Member

@slintes slintes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 24, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mshitrit, slintes

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mshitrit
Copy link
Member Author

mshitrit commented Aug 3, 2023

/unhold

@mshitrit mshitrit marked this pull request as ready for review August 3, 2023 13:08
@openshift-ci openshift-ci bot requested review from beekhof and razo7 August 3, 2023 13:08
@mshitrit
Copy link
Member Author

mshitrit commented Aug 3, 2023

/retest

@openshift-merge-robot openshift-merge-robot merged commit a6baa72 into medik8s:main Aug 3, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants