Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fetch ETCD Quorum Check fix for Unknown Guard Pod State #119

Merged
merged 1 commit into from
Feb 22, 2024

Conversation

razo7
Copy link
Member

@razo7 razo7 commented Feb 11, 2024

The fix includes the scenario where the guard pod is pending and the condition Ready is missing. Unknown guard pods state.
Follow up to #110

@openshift-ci openshift-ci bot requested review from beekhof and slintes February 11, 2024 10:32
@clobrano
Copy link
Contributor

Considering that the actual fix is inside common and that this commit "only" picks the new version, it is not clear what part of NMO would be affected. Could you rephrase the commit message to clarify that?

@razo7 razo7 changed the title Fetch ETCD Check fix for Unknown Guard Pod State Fetch ETCD Quorum Check fix for Unknown Guard Pod State Feb 20, 2024
The fix includes the scenario where the guard pod is pending and the condition Ready is missing. Unknown guard pods state. Used for Webhook validation of etcd quorum check
@razo7
Copy link
Member Author

razo7 commented Feb 20, 2024

/retest

Copy link
Contributor

openshift-ci bot commented Feb 22, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: clobrano, razo7

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit fb550a6 into medik8s:main Feb 22, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants