Skip to content

Commit

Permalink
Merge pull request #137 from k-keiichi-rh/ecoproject-1241
Browse files Browse the repository at this point in the history
Add log messages to trace OutOfServiceTaint remediation
  • Loading branch information
openshift-merge-robot authored Jul 20, 2023
2 parents e5798e6 + 990a2bc commit b7042da
Showing 1 changed file with 3 additions and 0 deletions.
3 changes: 3 additions & 0 deletions controllers/selfnoderemediation_controller.go
Original file line number Diff line number Diff line change
Expand Up @@ -871,6 +871,7 @@ func (r *SelfNodeRemediationReconciler) removeOutOfServiceTaint(node *v1.Node) e
r.logger.Error(err, "Failed to remove taint from node,", "node name", node.Name, "taint key", OutOfServiceTaint.Key, "taint effect", OutOfServiceTaint.Effect)
return err
}
r.logger.Info("outofservice taint removed", "new taints", node.Spec.Taints)
return nil
}

Expand All @@ -882,6 +883,7 @@ func (r *SelfNodeRemediationReconciler) isResourceDeletionCompleted(node *v1.Nod
}
for _, pod := range pods.Items {
if pod.Spec.NodeName == node.Name && r.isPodTerminating(&pod) {
r.logger.Info("waiting for terminating pod ", "pod name", pod.Name, "phase", pod.Status.Phase)
return false
}
}
Expand All @@ -892,6 +894,7 @@ func (r *SelfNodeRemediationReconciler) isResourceDeletionCompleted(node *v1.Nod
}
for _, va := range volumeAttachments.Items {
if va.Spec.NodeName == node.Name {
r.logger.Info("waiting for deleting volumeAttachement", "name", va.Name)
return false
}
}
Expand Down

0 comments on commit b7042da

Please sign in to comment.