Stop remediation when node not found

[mshitrit]

ECOPROJECT-1492

Incorrect Status Conditions in case non existed node in Remediation CR .
When SNR is created for a non existing node Processing condition is True and Reason is RemediationStarted.
Expected values are processing = false, succeeded = false with reason NodeNotFound.

[openshift-ci]

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

[mshitrit]

/test ?

[openshift-ci]

@mshitrit: The following commands are available to trigger required jobs:

• /test 4.11-ci-index-self-node-remediation-bundle
• /test 4.11-images
• /test 4.11-openshift-e2e
• /test 4.11-test
• /test 4.12-ci-index-self-node-remediation-bundle
• /test 4.12-images
• /test 4.12-openshift-e2e
• /test 4.12-test
• /test 4.13-ci-index-self-node-remediation-bundle
• /test 4.13-images
• /test 4.13-openshift-e2e
• /test 4.13-test
• /test 4.14-ci-index-self-node-remediation-bundle
• /test 4.14-images
• /test 4.14-openshift-e2e
• /test 4.14-test

Use /test all to run all jobs.

In response to this:

/test ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[mshitrit]

/test 4.12-openshift-e2e

[clobrano]

/lgtm

Giving a chance to get more feedbacks, feel free to unhold
/hold

[mshitrit]

/retest

[razo7]

NIT: I would follow the pattern of the const name match its value by updating the const name to be remediationStoppedByNHC

[slintes]

and NHC is signalling a timeout actually, not stopping or terminating anything 😉

[razo7]

Too many verbs for one action :D

[razo7]

NIT: Whenever we use verifyTypeConditions (in the UT file) the expected reason is explicitly written. Why not use the const from selfnoderemediation_controller.go -> Use RemediationStarted const instead of "RemediationStarted"

[slintes]

NIT: Whenever we use verifyTypeConditions (in the UT file) the expected reason is explicitly written. Why not use the const from selfnoderemediation_controller.go -> Use RemediationStarted const instead of "RemediationStarted"

when you reuse the same const, you don't detect typos in const values

[mshitrit]

/retest

[mshitrit]

/retest

[mshitrit]

/retest

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mshitrit, slintes

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [mshitrit,slintes]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[mshitrit]

/unhold