-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Provide TLS Certificate to kubelet service status request #143
Conversation
This change enhances the security of the kubelet service request in the control plane manager by providing a TLS certificate when making the request. - Provide a CertStorageReader to the Manager - Re-use PrepareCredentials function from certificates package to create the proper certificates - Change TLSConfig providing Certificates and setting InsecureSkipVerify to false see https://issues.redhat.com/browse/ECOPROJECT-1421 Signed-off-by: Carlo Lobrano <[email protected]>
Skipping CI for Draft Pull Request. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: clobrano The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/test ? |
@clobrano: The following commands are available to trigger required jobs:
Use In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/test 4.14-openshift-e2e |
@clobrano: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
wrong source branch |
This change enhances the security of the kubelet service request in the
control plane manager by providing a TLS certificate when making the
request.
the proper certificates
to false
see https://issues.redhat.com/browse/ECOPROJECT-1421