Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add events #153

Merged
merged 2 commits into from
Oct 26, 2023
Merged

Add events #153

merged 2 commits into from
Oct 26, 2023

Conversation

mshitrit
Copy link
Member

@mshitrit mshitrit commented Oct 24, 2023

as part of ECOPROJECT-1662 Adding events for better visibility of SNR remediation process.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 24, 2023

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 24, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mshitrit

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mshitrit
Copy link
Member Author

/test ?

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 24, 2023

@mshitrit: The following commands are available to trigger required jobs:

  • /test 4.12-ci-index-self-node-remediation-bundle
  • /test 4.12-images
  • /test 4.12-openshift-e2e
  • /test 4.12-test
  • /test 4.13-ci-index-self-node-remediation-bundle
  • /test 4.13-images
  • /test 4.13-openshift-e2e
  • /test 4.13-test
  • /test 4.14-ci-index-self-node-remediation-bundle
  • /test 4.14-images
  • /test 4.14-openshift-e2e
  • /test 4.14-test

Use /test all to run all jobs.

In response to this:

/test ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mshitrit
Copy link
Member Author

/test 4.12-openshift-e2e

Copy link
Contributor

@clobrano clobrano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left just a note, otherwise it's ok for me

controllers/selfnoderemediation_controller.go Show resolved Hide resolved
@clobrano
Copy link
Contributor

/lgtm
Giving others a chance to review as well, feel free to unhold
/hold

@openshift-ci openshift-ci bot added the lgtm label Oct 25, 2023
@mshitrit mshitrit marked this pull request as ready for review October 26, 2023 10:55
@mshitrit mshitrit changed the title [WIP] Add events Add events Oct 26, 2023
@mshitrit
Copy link
Member Author

/unhold

@openshift-ci openshift-ci bot merged commit 1e201e1 into medik8s:main Oct 26, 2023
14 checks passed
@mshitrit mshitrit deleted the add-events branch June 25, 2024 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants