print versions #154
print versions #154
Conversation
Signed-off-by: Michael Shitrit <[email protected]>
|
Skipping CI for Draft Pull Request. |
|
/test 4.12-openshift-e2e |
There was a problem hiding this comment.
I think git is missing for getting the git commit and the operator's version.
In addition, the build target could be updated according to this PR. But I haven't seen it being used in code, so this target might be redundant 🤷🏻♂️
| COPY main.go main.go | ||
| COPY hack/ hack/ | ||
| COPY api/ api/ | ||
| COPY controllers/ controllers/ | ||
| COPY pkg/ pkg/ | ||
| COPY install/ install/ | ||
| # Build |
There was a problem hiding this comment.
IIRC you are missing git which should be installed in line 3 and copied right before building the binary.
# for getting version info
COPY .git/ .git/
Signed-off-by: Michael Shitrit <[email protected]>
|
/lgtm |
Signed-off-by: Michael Shitrit <[email protected]>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: clobrano, mshitrit The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Adding info about go version (and additional info) in logs.
ECOPROJECT-1743